sonic-cfggen supports hwsku parameter #1631

qiluo-msft · 2018-04-20T23:58:18Z

and Install l2switch.j2 into templates directory

taoyl-ms · 2018-04-21T00:10:59Z

src/sonic-config-engine/setup.py

@@ -19,4 +20,7 @@ def get_test_suite():
      scripts=['sonic-cfggen'],
      install_requires=['lxml', 'jinja2', 'netaddr', 'ipaddr', 'pyyaml', 'pyangbind'],
      test_suite='setup.get_test_suite',
+      data_files=[
+        ('/usr/share/sonic/templates', glob.glob('data/*')),
+      ],
     )


Why do we install this file with sonic-config-engine? Shouldn't it go with base image? #Resolved

This file is only used by sonic-cfggen, and tested here. So no need to move.

In reply to: 183192364 [](ancestors = 183192364)

taoyl-ms · 2018-04-21T00:16:39Z

src/sonic-config-engine/sonic-cfggen

@@ -15,6 +15,7 @@ Examples:
 See usage string for detail description for arguments.
 """

+from __future__ import print_function


What's it for? Print to stderr? #Resolved

To write 'print' in the most compatible style, for example python3.

In reply to: 183192730 [](ancestors = 183192730)

taoyl-ms · 2018-04-21T00:17:57Z

src/sonic-config-engine/sonic-cfggen

+            }}}
+        deep_update(data, hardware_data)
+        (ports, _) = get_port_config(hwsku, platform, args.port_config)
+        if not bool(ports):


What's the difference between if not bool(ports): and if not ports: here? #Resolved

Fixed.

In reply to: 183192799 [](ancestors = 183192799)

lguohan · 2018-04-21T07:18:36Z

can you fix the test? #Resolved

lguohan · 2018-04-23T15:54:19Z

@qiluo-msft , can you check the test? #Resolved

qiluo-msft · 2018-04-24T05:03:02Z

Retest this please #Closed

lguohan · 2018-04-24T05:16:31Z

src/sonic-config-engine/tests/sample_output/l2switch.json

@@ -0,0 +1,107 @@
+{


we need management port configuration. #Resolved

This PR focuses on hwsku related feature.

In reply to: 183607010 [](ancestors = 183607010)

lguohan · 2018-04-24T16:18:15Z

@qiluo-msft , still failing build #Resolved

Signed-off-by: Qi Luo <[email protected]>

*Note*: tuned test data during cherry-pick

[installer]: Suppress tar xz warning about time stamp in the future, if date is not correctly set (sonic-net#1562) \[sonic-platform-common\] Update submodule (sonic-net#1563) \- Includes the following commits: \- \[bcmshell.py\] Match extra whitespace before prompt in regex (#3) \- add support for qsfp28 eeprom (#2) \[baseimage\]: bring down eth0 before restart networking (sonic-net#1555) cfggen generates new eth0 configuration. Need to first clean existing configuration on eth0 before bring up new configuration on eth0. Thus, we need to first bring down eth0 before putting new configuration into /etc/network/ interfaces \[mellanox\]: Update MLNX SAI pointer (sonic-net#1557) \[minigraph.py\] Add support to parse tacacs server information (sonic-net#1549) \* \[minigraph.py\] Add support to parse tacacs server information \[router advertiser\] Only start radvd process if device role is 'ToRRouter' (sonic-net#1569) \[submodules\]: update sonic-swss (sonic-net#1570) \[submodules\]: update sonic-utilities (sonic-net#1571) \[cfggen\]: ignore acl when its type is not defined (sonic-net#1568) \[installer\]: Umount before delete partition (sonic-net#1575) Use eth0 interface only to generate lldpd SystemId (sonic-net#1577) Allow one Service ACL to bind to multiple services (sonic-net#1576) \* \[caclmgrd\] Also ignore IP protocol if found in rule; we will only use our predefined protocols \[snmp\]: Bind snmpd to all ip addresses (sonic-net#1587) \[device\] Update Arista driver submodule (sonic-net#1585) Watchdog timeout increased \[devices\]: Fix type for qos.json in 7060 and S6100 (sonic-net#1582) \[minigraph\]: ignore minigraph ports which are not in port_config.ini (sonic-net#1593) \[minigraph\] Fix parser on PNG DeviceInterfaceLink Bandwidth (sonic-net#1592) \* \[minigraph\] Fix parser on PNG DeviceInterfaceLink Bandwidth \[Broadcom SAI\] upgrade Broadcom SAI to version 3.1.3.4-10 (sonic-net#1591) \* \[Broadcom SAI\] upgrade Broadcom SAI to version 3.1.3.4-9 Includes configuration files for following devices: \- Quanta 1X1B-32X \- Dell Z9264F \- Inventec D7054Q28B and D7032Q28B \* \[bcm sai\] upgrade sai version to 3.1.3.4-10 include configuration change to 7060 T0. 50G support for Arista 7060 (sonic-net#1580) \* 50G SKU for Arista 7060 Marvell's updates for SONiC 201803 over SAI v1.2 (sonic-net#1588) \[Mellanox\] Add support for a new platform LS-SN2700 \[devices\]: Merge ingress service pools of lossless and lossy traffic for TD2 (sonic-net#1578) \[sonic-utilities\] add pfcstat and queuestat tool (sonic-net#1606) Add support for S6100 switchport LEDs (sonic-net#1610) \[ip-in-ip\]: Fix config template to apply correct platform depended values (sonic-net#1619) \[platform-common\]: Update sonic-platform-common submodule (sonic-net#1620) \[sfputilbase\]: Add logic to parse the title of port_config.ini file \[sonic-cfggen\] Be case insensitive to hostname in minigraph (sonic-net#1614) \[bugfix\]: pass correct port name to led_control.py in ledd \[cfggen\]: Fix build by fixing pyangbind version (sonic-net#1633) \[swss\]: update sonic-swss submodule \* ea34b92 2018-04-24 | Fix tables handling race condition in buffermgr (sonic-net#484) (HEAD -> 201803, origin/201803) \[Andriy Moroz\] \* 53831be 2018-04-19 | \[pfcwd\]: create PFCWD acl instead of L3 ACL (sonic-net#479) \[sihuihan88\] \[radvd\] Ensure at least one interface is specified in radvd.conf before starting radvd (sonic-net#1636) \[updategraph\]: Keep updategraph service active after start (sonic-net#1651) \[docker-lldpd\]: Various fixes (sonic-net#1650) \* We don't need configure anything until we have interfaces created \* Don't run lldpcli for a port, until a port is up and running \* Remove lldpd socket before starting lldpd \* Fix sample files for lldpd configuration \* Another attempt to make the test working \* Quick fix for lldpd paused after start bug \[submodules\]: update swss and utilities modules swss: \* e34104e 2018-04-13 | \[pfcwd\]: support BIG_RED_SWITCH mode (sonic-net#467) (HEAD, origin/201803) \[sihuihan88\] \* 1f857d5 2018-04-25 | \[buffermgr\]: remove the item from consumer queue if invalid (sonic-net#489) \[sihuihan88\] utilities: \* 0b9bb2b 2018-04-26 | Stop services before pushing new config during "load_minigraph" (sonic-net#247) (HEAD, origin/201803) \[Prince Sunny\] \* dc119c9 2018-04-18 | \[show logging\] For following, change 'tail -f' to 'tail -F' in order to retry in the case log is rotated (sonic-net#240) \[Joe LeVeque\] \* 08da428 2018-04-16 | \[pfcwd\]: add cli to enable/disable BIG_RED_SWITCH mode (sonic-net#237) \[sihuihan88\] \[snmp\]: Fix a race between snmpd-config-updater and snmpd (sonic-net#1628) There is a small window in which snmpd might not have registered a callback for SIGHUP and which will result in its death if snmpd-config-updater send this signal meant for a config reload. \[snmpd\]: Fix typo in is_platform_arista (sonic-net#1634) \[mellanox\]: Update SAI version to 1.11.4 and SDK to 4.2.7303 (sonic-net#1655) \[docker-dhcp\]: Fix the sonic build issue (sonic-net#1659) Install the built version of isc-dhcp-client in docker-dhcp-relay \[swss\]: update swss 118b3f0 2018-05-01 | Populate existing interface cache, bring down before configDone \[zebra.conf\] Fix template issue with multiple lo addresses (sonic-net#1662) \* \[zebra.conf\] Fix template issue with multiple lo addresses \* Add unitest for Loopback1 \[swss\]: Change the hash seed to 0 for ToR and 10 for Leaf routers (sonic-net#1667) Due to some ASIC platform limitations, the hash seed range is from 0 to 15. Thus the switch.json.j2 template is updated so that ToRRouter is using hash seed 0 and LeafRouter is using hash seed 10. \[snmp\]: Stop spamming logs with statfs permission denied log message (sonic-net#1668) \[broadcom\]: update broadcom SAI to 3.1.3.4-11 (sonic-net#1670) Provide better ECMP load-balancing via hash seed \[sonic-cfggen\]: fix bgpd and zebra template for sonic-cfggen test I took the original patch (bebb7a0) into 201803 branch need to also adapt the patch since we do not have commit (d423841) in 201803 branch. \[swss\]: update sonic-swss module \[201803 d57f9a1\] \[lua\]: use not to check whether the field exists (sonic-net#492) \[device\] Update arista driver submodule (sonic-net#1674) \[submodule\]: Update submodule sonic-snmpagent (sonic-net#1642) sonic-cfggen supports hwsku parameter (sonic-net#1631) \*Note\*: tuned test data during cherry-pick \[device\] Add PSU utility for platform ly1200 of MiTAC (sonic-net#1673) \[platform/broadcom/sonic-platform-modules-mitac\] Install acpi package for daemon and adjust i2c sequence \[mellanox\]: Update MLNX SAI pointer (sonic-net#1684) 40G profile for Arista 7060 (sonic-net#1677) Update buffers config for Mellanox 27xx devices (sonic-net#1649) \* Update buffers config for Mellanox 27xx devices \* Remove buffers template test for msn27xx \[submodule\]: Update submodule sonic-snmpagent: Improve mib fundamental classes (sonic-net#1689) \[sonic-utilities\]: update sonic utilities submodule \* 951633b 2018-05-04 | \[generate_dump\]: fix a saidump file copy bug (sonic-net#248) (HEAD, origin/201803) \[Kebo Liu\] \* 69baff7 2018-05-03 | \[acl_loader\]: Missing one colon (sonic-net#252) \[Shuotian Cheng\] \* 557248d 2018-05-02 | \[acl-loader\]: Add --table_name option to update full operation (sonic-net#249) \[Shuotian Cheng\] \* a8aadee 2018-04-30 | \[acl-loader\]: Change the header from Rule ID to Table (sonic-net#250) \[Shuotian Cheng\] \[swss\]: update sonic-swss \* b57c376 2018-05-10 | \[teamsyncd\]: Add team_ifindex2ifname return value check (sonic-net#500) (HEAD, origin/201803) \[Shuotian Cheng\] \* 236843f 2018-05-07 | Fix Crm Acl used counter update (sonic-net#496) \[Nadiya\] \[swss\]: update sonic-swss c374357 2018-04-23 | Fix ZeroBufferProfile parameters (sonic-net#485) (HEAD -> 201803) \[Andriy Moroz\] \[platform\]: Fixed Cavium platform modules build. (sonic-net#1694) \[submodule\]: Update submodule sonic-snmpagent: Improve mib fundamental classes: retry after reinit_data() throws (sonic-net#1700) Merge branch 'github-1803' Conflicts: dockers/docker-router-advertiser/start.sh platform/broadcom/sai.mk platform/mellanox/mlnx-sai.mk src/sonic-config-engine/sonic-cfggen src/sonic-config-engine/tests/sample_output/ports.json src/sonic-config-engine/tests/test_cfggen.py src/sonic-platform-daemons src/sonic-snmpagent src/sonic-swss src/sonic-utilities \[baseimage\]: Disable DAD for eth0 explicitly (sonic-net#1701) \[quagga\]: update quagga submodule (sonic-net#1698) \* \[quagga\]: update quagga submodule 0bc6bd6 2018-05-11 | ignore nexthop attribute when NLRI is present (#18) (HEAD, origin/debian/0.99.24.1, origin/HEAD) \[lguohan\] \* add vs bgp test Fix the build error Revert "\[sonic-cfggen\]: fix bgpd and zebra template for sonic-cfggen test" This reverts commit b29d835. Fix the build issue for sonic-cfggen test Merge branch 'github-1803' --5/12 Conflicts: src/sonic-quagga src/sonic-snmpagent RB=1312391 G=lnos-reviewers R=pchaudha,pmao,rmolina,zxu A=

…ry (sonic-net#1631)

Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes. * src/sonic-sairedis 13474d1...bc58b0f (12): > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (#809) > Remove gbsyncd_start.sh (#808) > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (#807) > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (#791) > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (#799) > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (#797) > [vs] Add special warm boot logic to populate default attributes (#796) > [ci]: add vstest (#795) > [tests] Add macsec unittest (#782) > [debian/control] libsairedis-dev depends on libzmq5-dev (#794) > [ci]: use build template (#793) > Rename duplicate file name (#773) * src/sonic-swss 0b0d24c...5adb73e (47): > Initialize system port type variable (#1681) > [Dynamic Buffer Calc] Enhance the field checking in table handling (#1680) > Handle the clear request for 'Q_SHARED_ALL' (#1653) > [MuxOrch] FDB ageout safety check (#1674) > Deactivate mirror session only when session status is true in updateLagMember (#1666) > Revert "[buffermgr] Support maximum port headroom checking (#1607)" (#1675) > reduce severity of log to info in case of flush on non-existing member (#1669) > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (#1652)" (#1676) > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (#1652) > [acl] Move ACL table constants to acltable.h (#1671) > [nbrmgrd] added function to parse IP address from APP_DB (#1672) > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (#1670) > [vog/systemlag] Voq lagid allocator (#1603) > Add table descriptions for dynamic buffer calculation to the documents (#1664) > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (#1663) > Remove vxlanmgrd dependency on orchagent (#1647) > Keep attribute order in bulk mode (#1659) > [mux] VS test for neigh, route and fdb (#1656) > [linksync] Netdev oper status determination using IFF_RUNNING (#1568) > [portorch] parse on/off value from autoneg (#1658) > [intfsorch] Create subport with the entry contains necessary attributes (#1650) > [ci]: Purge swss before install (#1654) > Update StateDB with error if state change failed, Update APP_DB in all state chg req (#1662) > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (#1556) > [synchronous mode] Add failure notification for SAI failures in synchronous mode (#1596) > [acl] Enable VLAN ID qualifier for ACL rules (#1648) > Updated PFCWD to use single ACL table for PFCWD and MUX (#1620) > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (#1637) > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust > [vstest]: add dvs_route fixture > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (#1634) > Remove useless header in macsecorch (#1628) > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (#1600) > fixed unsupported resource issue (#1641) > [test_virtual_chassis]: use wait_for to make test more robust (#1640) > spell check fixes (#1630) > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (#1639) > [ci]: run vstest > [test_virtual_chassis]: use wait_for function to improve test robustness > [Mux] Neighbor handling based on FDB entry (#1631) > [ci]: use build template (#1633) > Log level change from ERR to INFO for fetch systemports issue (#1632) > Migrate serdes programming to port serdes object (#1611) > [tests] Remove legacy saiattributelist.h dependency (#1608) > [buffermgr] Support maximum port headroom checking (#1607) > Support shared headroom pool on top of dynamic buffer calculation (#1581) > Fix the compiling errors in gcc9 (#1621)

Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes. * src/sonic-sairedis 13474d1...bc58b0f (12): > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (sonic-net#809) > Remove gbsyncd_start.sh (sonic-net#808) > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (sonic-net#807) > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (sonic-net#791) > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (sonic-net#799) > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (sonic-net#797) > [vs] Add special warm boot logic to populate default attributes (sonic-net#796) > [ci]: add vstest (sonic-net#795) > [tests] Add macsec unittest (sonic-net#782) > [debian/control] libsairedis-dev depends on libzmq5-dev (sonic-net#794) > [ci]: use build template (sonic-net#793) > Rename duplicate file name (sonic-net#773) * src/sonic-swss 0b0d24c...5adb73e (47): > Initialize system port type variable (sonic-net#1681) > [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680) > Handle the clear request for 'Q_SHARED_ALL' (sonic-net#1653) > [MuxOrch] FDB ageout safety check (sonic-net#1674) > Deactivate mirror session only when session status is true in updateLagMember (sonic-net#1666) > Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675) > reduce severity of log to info in case of flush on non-existing member (sonic-net#1669) > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)" (sonic-net#1676) > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652) > [acl] Move ACL table constants to acltable.h (sonic-net#1671) > [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672) > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670) > [vog/systemlag] Voq lagid allocator (sonic-net#1603) > Add table descriptions for dynamic buffer calculation to the documents (sonic-net#1664) > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663) > Remove vxlanmgrd dependency on orchagent (sonic-net#1647) > Keep attribute order in bulk mode (sonic-net#1659) > [mux] VS test for neigh, route and fdb (sonic-net#1656) > [linksync] Netdev oper status determination using IFF_RUNNING (sonic-net#1568) > [portorch] parse on/off value from autoneg (sonic-net#1658) > [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650) > [ci]: Purge swss before install (sonic-net#1654) > Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662) > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (sonic-net#1556) > [synchronous mode] Add failure notification for SAI failures in synchronous mode (sonic-net#1596) > [acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648) > Updated PFCWD to use single ACL table for PFCWD and MUX (sonic-net#1620) > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (sonic-net#1637) > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust > [vstest]: add dvs_route fixture > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634) > Remove useless header in macsecorch (sonic-net#1628) > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (sonic-net#1600) > fixed unsupported resource issue (sonic-net#1641) > [test_virtual_chassis]: use wait_for to make test more robust (sonic-net#1640) > spell check fixes (sonic-net#1630) > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (sonic-net#1639) > [ci]: run vstest > [test_virtual_chassis]: use wait_for function to improve test robustness > [Mux] Neighbor handling based on FDB entry (sonic-net#1631) > [ci]: use build template (sonic-net#1633) > Log level change from ERR to INFO for fetch systemports issue (sonic-net#1632) > Migrate serdes programming to port serdes object (sonic-net#1611) > [tests] Remove legacy saiattributelist.h dependency (sonic-net#1608) > [buffermgr] Support maximum port headroom checking (sonic-net#1607) > Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1581) > Fix the compiling errors in gcc9 (sonic-net#1621)

5a7c06a0 [config]][tacacs+] Change tacacs+ minimum timeout value base on spec (sonic-net#1631) 080a689c [202012] [db_migrator] fix old 1911 feature config migration to a new one. (sonic-net#1636) 43fff88c Change to use rvtysh when calling the show commands (sonic-net#1646) 88a823f0 [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (sonic-net#1564) d096ff78 [config]Static routes to config_db (sonic-net#1534) a68d8d09 route_check: Updates (sonic-net#1645) Signed-off-by: Stephen Sun <[email protected]>

Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes. * src/sonic-sairedis 13474d1...bc58b0f (12): > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (sonic-net#809) > Remove gbsyncd_start.sh (sonic-net#808) > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (sonic-net#807) > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (sonic-net#791) > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (sonic-net#799) > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (sonic-net#797) > [vs] Add special warm boot logic to populate default attributes (sonic-net#796) > [ci]: add vstest (sonic-net#795) > [tests] Add macsec unittest (sonic-net#782) > [debian/control] libsairedis-dev depends on libzmq5-dev (sonic-net#794) > [ci]: use build template (sonic-net#793) > Rename duplicate file name (sonic-net#773) * src/sonic-swss 0b0d24c...5adb73e (47): > Initialize system port type variable (sonic-net#1681) > [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680) > Handle the clear request for 'Q_SHARED_ALL' (sonic-net#1653) > [MuxOrch] FDB ageout safety check (sonic-net#1674) > Deactivate mirror session only when session status is true in updateLagMember (sonic-net#1666) > Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675) > reduce severity of log to info in case of flush on non-existing member (sonic-net#1669) > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)" (sonic-net#1676) > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652) > [acl] Move ACL table constants to acltable.h (sonic-net#1671) > [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672) > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670) > [vog/systemlag] Voq lagid allocator (sonic-net#1603) > Add table descriptions for dynamic buffer calculation to the documents (sonic-net#1664) > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663) > Remove vxlanmgrd dependency on orchagent (sonic-net#1647) > Keep attribute order in bulk mode (sonic-net#1659) > [mux] VS test for neigh, route and fdb (sonic-net#1656) > [linksync] Netdev oper status determination using IFF_RUNNING (sonic-net#1568) > [portorch] parse on/off value from autoneg (sonic-net#1658) > [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650) > [ci]: Purge swss before install (sonic-net#1654) > Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662) > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (sonic-net#1556) > [synchronous mode] Add failure notification for SAI failures in synchronous mode (sonic-net#1596) > [acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648) > Updated PFCWD to use single ACL table for PFCWD and MUX (sonic-net#1620) > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (sonic-net#1637) > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust > [vstest]: add dvs_route fixture > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634) > Remove useless header in macsecorch (sonic-net#1628) > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (sonic-net#1600) > fixed unsupported resource issue (sonic-net#1641) > [test_virtual_chassis]: use wait_for to make test more robust (sonic-net#1640) > spell check fixes (sonic-net#1630) > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (sonic-net#1639) > [ci]: run vstest > [test_virtual_chassis]: use wait_for function to improve test robustness > [Mux] Neighbor handling based on FDB entry (sonic-net#1631) > [ci]: use build template (sonic-net#1633) > Log level change from ERR to INFO for fetch systemports issue (sonic-net#1632) > Migrate serdes programming to port serdes object (sonic-net#1611) > [tests] Remove legacy saiattributelist.h dependency (sonic-net#1608) > [buffermgr] Support maximum port headroom checking (sonic-net#1607) > Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1581) > Fix the compiling errors in gcc9 (sonic-net#1621)

* Mux neighbor handling based on FDB entry

qiluo-msft requested review from taoyl-ms, stcheng and lguohan April 20, 2018 23:58

taoyl-ms reviewed Apr 21, 2018

View reviewed changes

qiluo-msft force-pushed the qiluo/l2 branch 2 times, most recently from 2466b5b to 957e04d Compare April 21, 2018 05:54

qiluo-msft force-pushed the qiluo/l2 branch from 957e04d to 385fccd Compare April 21, 2018 18:22

qiluo-msft force-pushed the qiluo/l2 branch from 5d257a3 to 161ac8e Compare April 23, 2018 17:42

lguohan reviewed Apr 24, 2018

View reviewed changes

qiluo-msft added 10 commits April 24, 2018 19:20

sonic-cfggen supports hwsku parameter

4444249

Signed-off-by: Qi Luo <[email protected]>

Install l2switch.j2 into templates directory

a41ad22

Signed-off-by: Qi Luo <[email protected]>

Add test case

95353c8

Signed-off-by: Qi Luo <[email protected]>

Specify jinja2 required version

775aea9

Signed-off-by: Qi Luo <[email protected]>

Install new version of jinja2 when building

798424f

Install latest version of pip when building, so we could install jinja2

6da1feb

Signed-off-by: Qi Luo <[email protected]>

Refine code

46cedda

Signed-off-by: Qi Luo <[email protected]>

Fix pip2 version for pyangbind

6aa03c5

Signed-off-by: Qi Luo <[email protected]>

Fix pip jinja

fd2998a

Signed-off-by: Qi Luo <[email protected]>

Refine pip installation

2df0f3a

Signed-off-by: Qi Luo <[email protected]>

qiluo-msft force-pushed the qiluo/l2 branch from 55bbce4 to 2df0f3a Compare April 24, 2018 20:21

lguohan approved these changes Apr 24, 2018

View reviewed changes

qiluo-msft merged commit d117172 into sonic-net:master Apr 24, 2018

qiluo-msft deleted the qiluo/l2 branch April 24, 2018 23:01

qiluo-msft added a commit that referenced this pull request May 4, 2018

sonic-cfggen supports hwsku parameter (#1631)

532953e

*Note*: tuned test data during cherry-pick

daall mentioned this pull request Feb 17, 2021

[202012][submodule] Update sonic-swss and sonic-utilities submodules #6798

Merged

4 tasks

prsunny added a commit to prsunny/sonic-buildimage that referenced this pull request Mar 2, 2021

[Submodule] update to commit [Mux] Neighbor handling based on FDB ent…

30b7fc1

…ry (sonic-net#1631)

jleveque mentioned this pull request Mar 18, 2021

[sonic-sairedis][sonic-swss] Update submodules #7089

Merged

theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022

[Mux] Neighbor handling based on FDB entry (sonic-net#1631)

3f11a50

* Mux neighbor handling based on FDB entry

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sonic-cfggen supports hwsku parameter #1631

sonic-cfggen supports hwsku parameter #1631

qiluo-msft commented Apr 20, 2018

taoyl-ms Apr 21, 2018 •

edited by qiluo-msft

Loading

qiluo-msft Apr 21, 2018

taoyl-ms Apr 21, 2018 •

edited by qiluo-msft

Loading

qiluo-msft Apr 21, 2018

taoyl-ms Apr 21, 2018 •

edited by qiluo-msft

Loading

qiluo-msft Apr 21, 2018

lguohan commented Apr 21, 2018 •

edited by qiluo-msft

Loading

lguohan commented Apr 23, 2018 •

edited by qiluo-msft

Loading

qiluo-msft commented Apr 24, 2018 •

edited

Loading

lguohan Apr 24, 2018 •

edited by qiluo-msft

Loading

qiluo-msft Apr 24, 2018

lguohan commented Apr 24, 2018 •

edited by qiluo-msft

Loading

sonic-cfggen supports hwsku parameter #1631

sonic-cfggen supports hwsku parameter #1631

Conversation

qiluo-msft commented Apr 20, 2018

taoyl-ms Apr 21, 2018 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Apr 21, 2018

Choose a reason for hiding this comment

taoyl-ms Apr 21, 2018 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Apr 21, 2018

Choose a reason for hiding this comment

taoyl-ms Apr 21, 2018 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Apr 21, 2018

Choose a reason for hiding this comment

lguohan commented Apr 21, 2018 • edited by qiluo-msft Loading

lguohan commented Apr 23, 2018 • edited by qiluo-msft Loading

qiluo-msft commented Apr 24, 2018 • edited Loading

lguohan Apr 24, 2018 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Apr 24, 2018

Choose a reason for hiding this comment

lguohan commented Apr 24, 2018 • edited by qiluo-msft Loading

taoyl-ms Apr 21, 2018 •

edited by qiluo-msft

Loading

taoyl-ms Apr 21, 2018 •

edited by qiluo-msft

Loading

taoyl-ms Apr 21, 2018 •

edited by qiluo-msft

Loading

lguohan commented Apr 21, 2018 •

edited by qiluo-msft

Loading

lguohan commented Apr 23, 2018 •

edited by qiluo-msft

Loading

qiluo-msft commented Apr 24, 2018 •

edited

Loading

lguohan Apr 24, 2018 •

edited by qiluo-msft

Loading

lguohan commented Apr 24, 2018 •

edited by qiluo-msft

Loading