Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asan] add address sanitizer support to docker-sonic-vs #10470

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

Yakiv-Huryk
Copy link
Contributor

@Yakiv-Huryk Yakiv-Huryk commented Apr 5, 2022

Add address sanitizer support to docker-sonic-vs

Why I did it

To support docker-sonic-vs image with ASAN.

How I did it

  • Made the supervisord.conf a template
  • Added the 'log_path' environment variable for ASAN-enabled daemons
  • Added supervisord.conf.j2 generation and ASAN lib to the docker-sonic-vs/Dockerfile.j2

How to verify it

  • Made a build with ENABLE_ASAN=y
  • Run the tests, checked ASAN reports

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@prsunny could you please help to review or suggest reviewer?

@saiarcot895
Copy link
Contributor

It may be useful to also have it dump a core file (adding disable_coredump=0:unmap_shadow_on_exit=1:abort_on_error=1), so that it'd be easier to debug the cause of the issue after it exists.

@Yakiv-Huryk
Copy link
Contributor Author

It may be useful to also have it dump a core file (adding disable_coredump=0:unmap_shadow_on_exit=1:abort_on_error=1), so that it'd be easier to debug the cause of the issue after it exists.

Currently, it's out of scope for this stage. The log with stack trace seems enough for the bugs that were found.
We might want to consider adding it in the future if we see that it's useful.

@liat-grozovik
Copy link
Collaborator

It may be useful to also have it dump a core file (adding disable_coredump=0:unmap_shadow_on_exit=1:abort_on_error=1), so that it'd be easier to debug the cause of the issue after it exists.

Currently, it's out of scope for this stage. The log with stack trace seems enough for the bugs that were found. We might want to consider adding it in the future if we see that it's useful.

i tend to agree. We have another feature of auto techsupport which is now extended to memory leaks and later can also be extended to asan. for now lets focus on enabling this functionality and later on enhance it

@liat-grozovik liat-grozovik merged commit 3abf383 into sonic-net:master Apr 22, 2022
@Yakiv-Huryk Yakiv-Huryk deleted the vs-asan branch April 22, 2022 12:49
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants