Bump psalm level

[VincentLanglet]

No description provided.

[VincentLanglet]

@sonata-project/contributors There is the following psalm error:

ERROR: InvalidNullableReturnType - src/FieldDescription/TypeGuesserChain.php:54:73 - The declared return type 'Symfony\Component\Form\Guess\TypeGuess' for Sonata\AdminBundle\FieldDescription\TypeGuesserChain::guess is not nullable, but 'Symfony\Component\Form\Guess\TypeGuess|null' contains null (see https://psalm.dev/144)
    public function guess(FieldDescriptionInterface $fieldDescription): TypeGuess


ERROR: NullableReturnStatement - src/FieldDescription/TypeGuesserChain.php:62:16 - The declared return type 'Symfony\Component\Form\Guess\TypeGuess' for Sonata\AdminBundle\FieldDescription\TypeGuesserChain::guess is not nullable, but the function returns 'Symfony\Component\Form\Guess\TypeGuess|null' (see https://psalm.dev/139)
        return TypeGuess::getBestGuess($guesses);

It's right, the TypeGuesserChain::guess could return null, for example if this class was created with no guesser.
But our persistent bundle are using it as there will always be a guess.

Should I add null to the return type and then the persistence bundle will throw an error if there is no guess (asking the developer to explicitely passing the type). Or should we add an exception in the TypeGuesserChain if no guess is found ?

[VincentLanglet]

The PR is now ready @sonata-project/contributors :)

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[VincentLanglet]

@wbloszyk I just discover that setTemplateRegistry is called in the AddDependencyCallsCompilerPass
I think setTemplates and setTemplate are called too.

The TaggedAdminInterface was meant to define all the setter called by this compiler pass.
Extending AbstractTaggedAdmin was supposed to be enough to work with the sonata.admin tag.

Should we move the methods from the MutableTemplateRegistryAwareInterface to the TaggedAdminInterface and from AbstractAdmin to AbstractTaggedAdmin ?
Or at least should the TaggedAdminInterface extends MutableTemplateRegistryAwareInterface ?

[jordisala1991]

The return phpdoc is wrong imo

[VincentLanglet]

    public function find(string $class, $id): ?object
    {
        return $this->repository->byId($id);
    }

Since the repository is a Foo repository, it always return Foo or null.

I had some trouble with this issue since the modelManager is suppose to return a value corresponding to the class, but is not doing this job in the tests...

[jordisala1991]

But did you try to remove the phpdoc? the interface already have that

[VincentLanglet]

If I remove the Phpdoc, I end with another error, from phpstan maybe.

[VincentLanglet]

Without the phpdoc I get

phpstan: Method Sonata\AdminBundle\Tests\App\Model\ModelManager::find() should return T of object|null but returns Sonata\AdminBundle\Tests\App\Model\Foo|null.

psalm: InvalidReturnStatement: The inferred type 'Sonata\AdminBundle\Tests\App\Model\Foo|null' does not match the declared return type '(T:fn-sonata\adminbundle\model\modelmanagerinterface::find as object)|null' for Sonata\AdminBundle\Tests\App\Model\ModelManager::find

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[franmomu]

Why suppressing these? can we add a comment?