Add setter check

sonata-project · Apr 6, 2021 · 57f6226 · 57f6226
1 parent a085bea
commit 57f6226
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/src/Model/AuditManager.php b/src/Model/AuditManager.php
@@ -38,6 +38,15 @@ public function __construct(ContainerInterface $container)
 
     public function setReader(string $serviceId, array $classes): void
     {
+        $reader = $this->container->get($serviceId);
+        if (!$reader instanceof AuditReaderInterface) {
+            throw new \InvalidArgumentException(sprintf(
+                'Service "%s" MUST implement interface "%s".',
+                $serviceId,
+                AuditReaderInterface::class,
+            ));
+        }
+
         $this->readers[$serviceId] = $classes;
     }
 

diff --git a/tests/Twig/Extension/CanonicalizeExtensionTest.php b/tests/Twig/Extension/CanonicalizeExtensionTest.php
@@ -24,9 +24,9 @@
 final class CanonicalizeExtensionTest extends TestCase
 {
     /**
-     * @var RequestStack
+     * @var Request
      */
-    private $requestStack;
+    private $request;
 
     /**
      * @var CanonicalizeExtension
@@ -35,9 +35,10 @@ final class CanonicalizeExtensionTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->requestStack = new RequestStack();
-        $this->requestStack->push(new Request());
-        $this->twigExtension = new CanonicalizeExtension($this->requestStack);
+        $this->request = new Request();
+        $requestStack = new RequestStack();
+        $requestStack->push($this->request);
+        $this->twigExtension = new CanonicalizeExtension($requestStack);
     }
 
     /**
@@ -242,9 +243,6 @@ public function select2LocalesProvider()
 
     private function changeLocale(string $locale): void
     {
-        $request = $this->requestStack->getCurrentRequest();
-        \assert(null !== $request);
-
-        $request->setLocale($locale);
+        $this->request->setLocale($locale);
     }
 }