Throw exception in the getter

sonata-project · Apr 11, 2021 · 84c87f8 · 84c87f8
1 parent dd90adc
commit 84c87f8
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/src/Model/AuditManager.php b/src/Model/AuditManager.php
@@ -38,15 +38,6 @@ public function __construct(ContainerInterface $container)
 
     public function setReader(string $serviceId, array $classes): void
     {
-        $reader = $this->container->get($serviceId);
-        if (!$reader instanceof AuditReaderInterface) {
-            throw new \InvalidArgumentException(sprintf(
-                'Service "%s" MUST implement interface "%s".',
-                $serviceId,
-                AuditReaderInterface::class,
-            ));
-        }
-
         $this->readers[$serviceId] = $classes;
     }
 
@@ -66,7 +57,13 @@ public function getReader(string $class): AuditReaderInterface
         foreach ($this->readers as $readerId => $classes) {
             if (\in_array($class, $classes, true)) {
                 $reader = $this->container->get($readerId);
-                \assert($reader instanceof AuditReaderInterface);
+                if (!$reader instanceof AuditReaderInterface) {
+                    throw new \LogicException(sprintf(
+                        'Service "%s" MUST implement interface "%s".',
+                        $readerId,
+                        AuditReaderInterface::class,
+                    ));
+                }
 
                 return $reader;
             }