feature/encore-webpack

[silasjoisten]

Subject

Closes #5454

• Add Upgrade Note
• Update Docs
• Automatically Read webpack_encore.builds and adding them to template
• Fix Tests
• Remove configuration: assets under sonata_admin
• Fix datetimepicker error
• Load Select2 locale component async
• Load momentJS locale component async
• Convert mapping of Translate some locales in order to match locales available from bower dependencies #4878 into javascript to provide async loading of language files

Review

• You can ignore the src/Resources/public/dist
• You need to add the following in your sonata_admin.yaml or webpack_encore.yaml

webpack_encore:
    builds:
        sonata_admin: '%kernel.project_dir%/public/bundles/sonataadmin/dist'
        app: '%kernel.project_dir%/public/build' # Handling multiple entry points.

There is a compiler pass which is reading the webpack_encore.builds config and adding them to twig globals. In template there will automtically added.

Reference

• https://symfony.com/doc/current/frontend/encore/split-chunks.html
• https://symfony.com/doc/current/frontend/encore/code-splitting.html
• Is there a way to work with multiple entrypoints ? symfony/webpack-encore-bundle#13 (comment)

Related PR

• SonataAdminBundle 4.0 WebpackEncore configuration symfony/recipes-contrib#714

[silasjoisten]

@OskarStark it never worked with jQuery 3 see https://github.com/sonata-project/SonataAdminBundle/blob/3.x/src/Resources/public/vendor/jquery/dist/jquery.js

The DateTimePicker lib just works with jQuery 2

[OskarStark]

Please add new line

[silasjoisten]

this is generated

[OskarStark]

Argh this should not happen, do you know where we need to head to provide a PR?

[OskarStark]

cc @weaverryan

[OskarStark]

friendly ping @weaverryan

[silasjoisten]

@OskarStark i figured out:

manifest.json is generated: https://github.com/symfony/webpack-encore/blob/master/lib/plugins/entry-files-manifest.js#L80

But for entrypoints.json i didn't find the place where that happens

[OskarStark]

Maybe we should add an option where he dont need to override the template.

Yes we should do this IMO

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[silasjoisten]

Maybe we should add an option where he dont need to override the template.

Yes we should do this IMO

@OskarStark i think a configuration option is not good for this, because this config is related to WebpackEncore. Maybe i update the FlexRecipe of SonataAdminBundle? What would you say?

[core23]

Should we include the dist folder (https://github.com/silasjoisten/SonataAdminBundle/tree/feature/encore-webpack/src/Resources/public/dist)? This disallows using the latest (secure) version of a frontend library.

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[silasjoisten]

Should we include the dist folder (https://github.com/silasjoisten/SonataAdminBundle/tree/feature/encore-webpack/src/Resources/public/dist)? This disallows using the latest (secure) version of a frontend library.

The other opportunity would be pushing to npm.js but this is not that as good because this "lib" wont work without the php stuff. I think its good to commit the dist folder and update manually from time to time. Other thing is that many frontend libs does not do sematic versioning so can be problematic to update them.

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[core23]

Can you give a short status report @silasjoisten ? Is this stable enough, so we can review and merge this?

[OskarStark]

Can you fix CS please?

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[core23]

The Checklist is completed? Is this RTM @silasjoisten ?

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[psyray]

@silasjoisten Thanks for your work 👍
Really looking forward to using webpack with Sonata :)

[wbloszyk]

@silasjoisten I'm working on your webpack. I will fix commits structure. . Dont use merge (branch) to update data. It blocks previus commits and make history ugly.

Also use git rebase to update data(move your branch to head other branch). Then you can add so many commits as you want (e.g. for testing). Before merge your PR to production you can merge commits to keep clear history. (e.g. documentation in this PR can be merge to one commit).

[VincentLanglet]

Hi @silasjoisten ! Is something missing in this PR or is it RTM ?
If something is missing, can we help you ? This PR would be great for the next major :)

@silasjoisten I'm working on your webpack.

Do you know what is missing to finish this PR @wbloszyk ?

[wbloszyk]

There is still some work to be done.

I also work with assets while sonata-project/dev-kit#697. After drop core i can finish this PR. Also will be nice to have upgraded sandbox to add encore to all sonata bundles (I have done AdminLTE and Bootstrap 4 branch).

Can you check:
sonata-project/sandbox#623

[nieuwenhuisen]

Can we help with anything to move this PR forward?

[wbloszyk]

@nieuwenhuisen This PR is not contributing for some time. I worked on it too. It is now move to sandbox (webpack branch). Here is issue for it:
sonata-project/dev-kit#779

BTW
You can help with extract javascript to webpack assets. If you intrested I will try to finish and merge sonata-project/sandbox#630 today. After that you will get tools to do it. This should help: https://github.com/sonata-project/sandbox/pull/630/files#diff-7fd7d5a1264ad8b6ca4aa13fd1341af2

[wbloszyk]

This PR should be done in https://github.com/sonata-project/sandbox/tree/webpack as proof of concept. Then we can easy move it to this repository.

Thank you for you current work @silasjoisten. It is awesone example.

If you want help and work on it feel free to reopen this PR.