AdminLTE 3 implementation #5989

wbloszyk · 2020-03-25T20:42:17Z

Subject

You can check result here:
http://demo.wbloszyk.pl

I am targeting this branch, because it is BC-break.

Changelog

### Added
- Added some `Class::newMethod` to do great stuff

### Changed

### Deprecated

### Removed

### Fixed

### Security

To do

Update - 07.07.2020

Current assets system have many dependencies to other Sonata bundles (like sonatacore files). It mean it is not simple to upgrade vendors and templates. It is possible to do it at once at major update but require upgrade all sonata bundles at once. To avoid it and allow upgrade sonata 3 to sonata 4 one by one bundle this thigs will be do:

new branch in sandbox where:
- add encore webpack
- add bootstrap4 and AdminLTE3
- prepare new templates
after finish this branch all this change will be split to bundles

SonataCI · 2020-03-28T15:31:40Z

Could you please rebase your PR and fix merge conflicts?

VincentLanglet · 2020-03-28T19:11:08Z

composer.json

+        "knplabs/knp-menu": "^2.0 || ^3.1",
+        "knplabs/knp-menu-bundle": "^2.3 || ^3.0",
+        "sonata-project/block-bundle": "^3.18.3 || ^4.0",


Why these changes ?

It is draft. I need it for working demo for now.

Ok, sorry for the too early review. 😅

VincentLanglet · 2020-03-28T19:14:19Z

I think this will need an upgrade note for the user.

If he made some custom page, override, etc. He'll be happy to know which class to use instead of the previous one.

Something like,
Before / After
box -> card
box-primary -> card-primary
...

wbloszyk · 2020-03-28T19:19:28Z

I think refer for adminlte and bootstrap upgrade will be enought.

VincentLanglet · 2020-03-28T19:20:35Z

src/Resources/public/vendor/admin-lte/.babelrc

@@ -0,0 +1,14 @@
+{


Do we have to commit all the admin-lte files ?
Can't we declare the dependency in the composer.json or something ?
Could we use https://packagist.org/packages/almasaeed2010/adminlte ?

VincentLanglet · 2020-03-28T19:34:40Z

I think refer for adminlte and bootstrap upgrade will be enought.

Unfortunaly the AdminLTE release notes doesnt help a lot https://github.com/ColorlibHQ/AdminLTE/releases

And I didn't found the reason for your changes in https://getbootstrap.com/docs/4.0/migration/#stable-changes

Something more precise than Update AdminLTE version from 2 to 3 could help the user.
When I took another look at your changes, and the only big change you made is actually

box box-primary

Into

card card-primary card-outline

What about adding a line in the upgrade note like

We're now using card card-primary card-outline instead of box box-primary ?

And if we makes some others class changes, adding a note for it.

wbloszyk · 2020-03-28T20:15:27Z

You can find adminlte upgrade guide here: https://adminlte.io/docs/3.0/upgrade-guide.html

I waiting for webpack. At first i will end "Drop SonataCoreBundle" PRs. At second "add support for BlockBundle 4.0. Then i will end this PR.

BTW If adminlte and bootstrap upgrade guide is not clear enought i can add own upgrade notes.

SonataCI · 2020-04-02T15:21:40Z

Could you please rebase your PR and fix merge conflicts?

SonataCI · 2020-04-03T15:32:43Z

Could you please rebase your PR and fix merge conflicts?

SonataCI · 2020-04-08T10:42:48Z

Could you please rebase your PR and fix merge conflicts?

SonataCI · 2020-04-18T08:31:45Z

Could you please rebase your PR and fix merge conflicts?

wbloszyk · 2020-06-19T07:52:30Z

What with #6147 ??

If x-editable will be drop then I can finish this PR.

jordisala1991 · 2020-06-19T08:04:38Z

IMHO #5461 this should be finish first, having to review 200k lines PR because we don't have assets correctly installed with npm is super hard and keep adding them makes that other PR harder and harder

wbloszyk · 2020-06-19T08:07:23Z

I dont want psuh assets but is require for tests.

BTW I will finish wecore too.

wbloszyk · 2020-06-20T08:05:15Z

#6145 (comment)

@greg0ire Can you merge 3.x branch to master in AdminBundle?

martinbroos · 2020-07-07T13:55:41Z

You can find adminlte upgrade guide here: https://adminlte.io/docs/3.0/upgrade-guide.html

I waiting for webpack. At first i will end "Drop SonataCoreBundle" PRs. At second "add support for BlockBundle 4.0. Then i will end this PR.

BTW If adminlte and bootstrap upgrade guide is not clear enought i can add own upgrade notes.

I'm happy to help with implementing these upgrades defined in the upgrade guide of Admin LTE3. As I can see the implementation is still incomplete. For instance admin LTE3 requires font-awesome5 which uses 'fas' instead of 'fa' when using icons.

Is it possible to ignore the webpack-encore update for now so we can get the theme implemented correctly. Others can help with this if we can get some of your code merged. If you want you can focus on 'Drop SonataCoreBundle' but my opinion is that we should not create a lot of dependencies between pull requests.

Could you fix the conflicts? Or is something else blocking this from merging ?

wbloszyk · 2020-07-07T17:35:29Z

The problem for now is x-editable not support bootstrap 4.

martinbroos · 2020-07-09T13:44:23Z

Ok thanks for your response. At the moment i'm not using x-editable and are using a custom theme. So hard to say if we should hold the release for this feature. We might be able to build something like this in combination with Popper.js which is part of admin lte 3 but it's hard to get it to work in way x-editable did with all those field types.
I'm not seeing any alternative library that provides this kind of functionality.

But if the goal is using bootstrap 4 and admin lte3 my advice is to disable x-editable for now so other can help with finding a replacement or further implement this theme.

VincentLanglet · 2020-07-09T14:24:31Z

There is an issue for this #6147
x-editable is not maintained anymore...

github-actions · 2021-04-19T11:18:22Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

wbloszyk added 2 commits March 25, 2020 17:56

Update admin-lte vendor

6fb3632

Upgrade admin-lte

6cc0848

wbloszyk changed the title ~~Master~~ AdminLTE 3 implementation Mar 25, 2020

wbloszyk added 10 commits March 26, 2020 08:56

Next update

17e5f40

Add sonatacore vendors

23e7236

Add popper.js

12da51a

Upgrade bootstrap

acc120a

Fix

d0fe0bb

Fix

03a45ff

Fix tests

97d7a51

Fix

f802f2d

fix

0567120

check in sandbox

452c799

VincentLanglet reviewed Mar 28, 2020

View reviewed changes

VincentLanglet added the Needs: Upgrade note label Mar 28, 2020

VincentLanglet reviewed Mar 28, 2020

View reviewed changes

Update

5b1babe

wbloszyk mentioned this pull request Apr 3, 2020

Next Major upgrade process for all bundles - propose #6016

Closed

Composer set

9001bda

Update composer

379a0e0

Support for KnpMenu 2.x

ed0af50

VincentLanglet mentioned this pull request May 5, 2020

Improve functionality by split Admin - concept for discussion #6079

Closed

wbloszyk mentioned this pull request Jun 19, 2020

Fix BC after drop twig/extensions #6145

Merged

wbloszyk added this to the 5.0 milestone Oct 21, 2020

github-actions bot added the stale label Apr 19, 2021

github-actions bot closed this Apr 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AdminLTE 3 implementation #5989

AdminLTE 3 implementation #5989

wbloszyk commented Mar 25, 2020 •

edited

Loading

SonataCI commented Mar 28, 2020

VincentLanglet Mar 28, 2020

wbloszyk Mar 28, 2020

wbloszyk Mar 28, 2020

VincentLanglet Mar 28, 2020

VincentLanglet commented Mar 28, 2020

wbloszyk commented Mar 28, 2020

VincentLanglet Mar 28, 2020

VincentLanglet commented Mar 28, 2020

wbloszyk commented Mar 28, 2020

SonataCI commented Apr 2, 2020

SonataCI commented Apr 3, 2020

SonataCI commented Apr 8, 2020

SonataCI commented Apr 18, 2020

wbloszyk commented Jun 19, 2020

jordisala1991 commented Jun 19, 2020

wbloszyk commented Jun 19, 2020 •

edited

Loading

wbloszyk commented Jun 20, 2020

martinbroos commented Jul 7, 2020

wbloszyk commented Jul 7, 2020

martinbroos commented Jul 9, 2020

VincentLanglet commented Jul 9, 2020

github-actions bot commented Apr 19, 2021

AdminLTE 3 implementation #5989

AdminLTE 3 implementation #5989

Conversation

wbloszyk commented Mar 25, 2020 • edited Loading

Subject

Changelog

To do

Update - 07.07.2020

SonataCI commented Mar 28, 2020

VincentLanglet Mar 28, 2020

Choose a reason for hiding this comment

wbloszyk Mar 28, 2020

Choose a reason for hiding this comment

wbloszyk Mar 28, 2020

Choose a reason for hiding this comment

VincentLanglet Mar 28, 2020

Choose a reason for hiding this comment

VincentLanglet commented Mar 28, 2020

wbloszyk commented Mar 28, 2020

VincentLanglet Mar 28, 2020

Choose a reason for hiding this comment

VincentLanglet commented Mar 28, 2020

wbloszyk commented Mar 28, 2020

SonataCI commented Apr 2, 2020

SonataCI commented Apr 3, 2020

SonataCI commented Apr 8, 2020

SonataCI commented Apr 18, 2020

wbloszyk commented Jun 19, 2020

jordisala1991 commented Jun 19, 2020

wbloszyk commented Jun 19, 2020 • edited Loading

wbloszyk commented Jun 20, 2020

martinbroos commented Jul 7, 2020

wbloszyk commented Jul 7, 2020

martinbroos commented Jul 9, 2020

VincentLanglet commented Jul 9, 2020

github-actions bot commented Apr 19, 2021

wbloszyk commented Mar 25, 2020 •

edited

Loading

wbloszyk commented Jun 19, 2020 •

edited

Loading