-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added assets version information #5299
Conversation
So what is the plan, is it outlined somewhere? Roughly (correct me if I am wrong),
|
That's the idea. My idea was to make the dependencies visible in the first step. I'm not that deep into the npm versioning, but can't we leave the php source and assets sources in the same repository and use git versioning for both? |
No idea, I guess we need someone that knows npm better than us |
@@ -0,0 +1,26 @@ | |||
{ | |||
"name": "@sonata-project/admin-bundle", | |||
"version": "0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 0.1.0? Why not the current version of sonata-admin package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're little stuck on the asset problem. We can't use the current composer project version for the assets, because there we have no specific release process for the assets and they're not changing very often.
Also, why not to remove bower from the project at all and configure npm packages properly? And why npm and not yarn, for example? |
Can you help with this?
IMHO yarn and npm are not that much different in handling package dependencies. They only use different technics for fetching them from the web. |
Yes, of course! But here is one kind of problem: npm doesn't support custom output directory. I think about this and have an idea to make postinstall script which moves |
The idea is, that we don't have any vendor assets in our project. But no idea how to do this, as symfony doesn't have any good solution so far (symfony/webpack-encore#5) |
Why not using the Symfony Webpack way? |
There is no way to support asset dependencies of other bundles. You can only add assets for your projects. You don't know if a specific version of an asset (e.g. jQuery 2) will work with the bundle you require. |
Can we merge this? |
As for me it's useless in current state and will confuse developers who want to extend it somehow (bower/npm). |
Closing this in favor of #5461 |
I am targeting this branch, because this is pedantic.
Changelog
Subject
This is the first step to remove external assets from this bundle.