Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop padding new append vecs to page size #33658

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

We no longer 'append' to append vecs. We know the full size when we are ready to write to them. So, it is no longer necessary to pad them to the next full page size. This makes 100% of the data in the file required and the used length equal to the allocated length.

This pr was attempted as #33607 but reverted as #33634.
There were 2 conflicting prs. There was a failing test. That test has now been fixed.

Summary of Changes

Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review October 11, 2023 15:23
brooksprumo
brooksprumo previously approved these changes Oct 11, 2023
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

steviez
steviez previously approved these changes Oct 11, 2023
@jeffwashington jeffwashington dismissed stale reviews from steviez and brooksprumo via 1d4ab52 October 11, 2023 18:01
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #33658 (1d4ab52) into master (fa21a3d) will decrease coverage by 0.1%.
Report is 7 commits behind head on master.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #33658     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         806      806             
  Lines      217477   217472      -5     
=========================================
- Hits       178026   178008     -18     
- Misses      39451    39464     +13     

@jeffwashington jeffwashington merged commit c354879 into solana-labs:master Oct 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants