Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "stop padding new append vecs to page size (#33607)" #33634

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Oct 10, 2023

This reverts commit b7962a3.

Problem

#33607 and #33608 have broken CI for the tip of master

running 1 test
test accounts_db::tests::test_shrink_collect_simple ... FAILED

failures:

---- accounts_db::tests::test_shrink_collect_simple stdout ----
thread 'accounts_db::tests::test_shrink_collect_simple' panicked at accounts-db/src/accounts_db.rs:17401:33:
assertion `left == right` failed
  left: 272
 right: 4096
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

These two commits were introduced in parallel, which means CI never previously ran with only one of the commits. Each individual commit on top of master passes CI, but the combination of the two fails

Summary of Changes

Revert #33607

@steviez
Copy link
Contributor Author

steviez commented Oct 10, 2023

FYI @jeffwashington

@jeffwashington jeffwashington self-requested a review October 10, 2023 19:40
Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crud, my bad.

@steviez
Copy link
Contributor Author

steviez commented Oct 10, 2023

Pushing early since all other CI is blocked at the moment, and I confirmed the previously failing unit test passes with this revert

@steviez steviez merged commit 982d29c into solana-labs:master Oct 10, 2023
16 checks passed
@steviez steviez deleted the revert_33607 branch October 21, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants