Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop padding new append vecs to page size #33607

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

We no longer 'append' to append vecs. We know the full size when we are ready to write to them. So, it is no longer necessary to pad them to the next full page size. This makes 100% of the data in the file required and the used length equal to the allocated length.

Summary of Changes

Fixes #

@HaoranYi
Copy link
Contributor

HaoranYi commented Oct 9, 2023

seems a bench test failed.

[2023-10-09T23:01:42.809916369Z ERROR solana_accounts_bench] results different:

  | (AccountsHash(3T99DHTbjqBrqnUEBzAng7rZgdyVDwDNf5eY4HGR6pHi), 12505000)
  | (AccountsHash(GKot5hBsd81kMupNCXHaqbhv3huEbxAFMLnpcX2hniwn), 0)
  | hash,3T99DHTbjqBrqnUEBzAng7rZgdyVDwDNf5eY4HGR6pHi,hash took 16ms,hash using store took 25ms,151%

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #33607 (cec2e55) into master (1d91b60) will increase coverage by 0.0%.
Report is 9 commits behind head on master.
The diff coverage is 92.1%.

@@           Coverage Diff           @@
##           master   #33607   +/-   ##
=======================================
  Coverage    81.7%    81.7%           
=======================================
  Files         807      807           
  Lines      218252   218263   +11     
=======================================
+ Hits       178438   178456   +18     
+ Misses      39814    39807    -7     

Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffwashington jeffwashington merged commit b7962a3 into solana-labs:master Oct 10, 2023
16 checks passed
steviez pushed a commit to steviez/solana that referenced this pull request Oct 10, 2023
steviez pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants