Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove wasm-pack version lock #32307

Merged
merged 2 commits into from
Jun 28, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ci/docker-rust/Dockerfile
Original file line number Diff line number Diff line change
@@ -2,7 +2,6 @@
# ci/rust-version.sh to pick up the new image tag
FROM rust:1.69.0

# we need to pin wasm-pack due to https://github.com/rustwasm/wasm-pack/issues/1308
RUN set -x \
&& apt update \
&& apt-get install apt-transport-https \
@@ -38,7 +37,7 @@ RUN set -x \
&& cargo install mdbook \
&& cargo install mdbook-linkcheck \
&& cargo install svgbob_cli \
&& cargo install --version 0.11.1 wasm-pack \
&& cargo install wasm-pack \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about removing comment at line 5?, which was added at #32239

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for pointing this out! 6085660

&& cargo install sccache \
&& rustc --version \
&& cargo --version