ci: remove wasm-pack version lock #32307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
reviewed
Jun 28, 2023
| @@ -38,7 +38,7 @@ RUN set -x \ | |||
| && cargo install mdbook \ | |||
| && cargo install mdbook-linkcheck \ | |||
| && cargo install svgbob_cli \ | |||
| && cargo install --version 0.11.1 wasm-pack \ | |||
| && cargo install wasm-pack \ | |||
solana-grimes
removed
the
automerge
|
😱 New commits were pushed while the automerge label was present. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we added a version lock for wasm-pack cuz they removed
--versionaccidentally. A good news is that they brought it back in 0.12.1. (https://github.com/rustwasm/wasm-pack/releases/tag/v0.12.1)Summary of Changes
remove the wasm-pack version lock