Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm-pack #32239

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix wasm-pack #32239

merged 1 commit into from
Jun 22, 2023

Conversation

ryoqun
Copy link
Member

@ryoqun ryoqun commented Jun 22, 2023

Problem

docker image update at #32234 updated various other commands and wasm-pack introduced some compatibility issue:

+ wasm-pack --version
error: unexpected argument '--version' found
 
  tip: a similar argument exists: '--verbose'
 
Usage: wasm-pack <--verbose...|--quiet|--log-level <LOG_LEVEL>> <COMMAND>

already reported to upstream: rustwasm/wasm-pack#1308

Summary of Changes

Pin it for now.

Fixes #

@ryoqun ryoqun requested a review from yihau June 22, 2023 05:01
@ryoqun
Copy link
Member Author

ryoqun commented Jun 22, 2023

@yihau hey, it seems my request at #32234 (review) caused unintended issue. Pinning is more desired than, asking all teammates to rebase for this thing. so, could you update the images again? sorry for the extra troubles...

Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just uploaded them again! thank you for the quick fixing 🫶

@yihau
Copy link
Member

yihau commented Jun 22, 2023

btw, they don't need to rebase. they only need to retry their pipeline 🔄

@ryoqun
Copy link
Member Author

ryoqun commented Jun 22, 2023

seems this is fixed by now. thanks! merging...

@ryoqun ryoqun merged commit 830c0ad into solana-labs:master Jun 22, 2023
HaoranYi pushed a commit to HaoranYi/solana that referenced this pull request Jun 22, 2023
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants