Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Install cargo-hack for upcoming dev-utils #32234

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

ryoqun
Copy link
Contributor

@ryoqun ryoqun commented Jun 22, 2023

Problem

#32169 is getting some positive feedback and we need to install cargo hack in preparation of it: https://github.com/solana-labs/solana/pull/32169/files#r1237437440

Summary of Changes

Install in advance.

@ryoqun ryoqun requested a review from yihau June 22, 2023 01:15
@ryoqun
Copy link
Contributor Author

ryoqun commented Jun 22, 2023

@yihau could you review this and update docker images in your spare time? thanks a lot.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #32234 (25a556c) into master (c142ba1) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #32234     +/-   ##
=========================================
- Coverage    82.0%    82.0%   -0.1%     
=========================================
  Files         769      769             
  Lines      209137   209137             
=========================================
- Hits       171587   171554     -33     
- Misses      37550    37583     +33     

Copy link
Contributor

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! just updated solanalabs/rust:1.69.0 and solanalabs/rust-nightly:2023-04-19

@ryoqun ryoqun mentioned this pull request Jun 22, 2023
@ryoqun ryoqun merged commit cc0fb5a into solana-labs:master Jun 22, 2023
@ryoqun
Copy link
Contributor Author

ryoqun commented Jun 22, 2023

I merged this just in case the docker re-update for #32239 won't miss cargo-hack and rebased #32239 ... cc: @yihau

HaoranYi pushed a commit to HaoranYi/solana that referenced this pull request Jun 22, 2023
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants