Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zk-token-sdk](docs) Update docs to include a brief description of how fee sigma proof is computed #32288

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

samkim-crypto
Copy link
Contributor

@samkim-crypto samkim-crypto commented Jun 27, 2023

Problem

The docs in the sigma_proofs module could be added/improved.

Summary of Changes

This PR touches docs only.

Fixes #

@samkim-crypto samkim-crypto added the work in progress This isn't quite right yet label Jun 27, 2023
@samkim-crypto samkim-crypto changed the title [zk-token-sdk(docs-only)] Update docs to include a brief description of how fee sigma proof is computed [zk-token-sdk](docs) Update docs to include a brief description of how fee sigma proof is computed Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #32288 (85bd1a1) into master (9fb105c) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

❗ Current head 85bd1a1 differs from pull request most recent head e744be9. Consider uploading reports for the commit e744be9 to get more accurate results

@@            Coverage Diff            @@
##           master   #32288     +/-   ##
=========================================
- Coverage    82.0%    82.0%   -0.1%     
=========================================
  Files         772      772             
  Lines      209538   209480     -58     
=========================================
- Hits       171973   171900     -73     
- Misses      37565    37580     +15     

@samkim-crypto samkim-crypto force-pushed the zk-token-sdk/sigma_proof_docs branch from d9f0366 to 89379b8 Compare June 27, 2023 06:57
@samkim-crypto samkim-crypto added v1.16 PRs that should be backported to v1.16 and removed work in progress This isn't quite right yet labels Jun 27, 2023
@samkim-crypto samkim-crypto force-pushed the zk-token-sdk/sigma_proof_docs branch from 301a844 to e744be9 Compare June 28, 2023 00:00
@samkim-crypto samkim-crypto merged commit 5624aaa into master Jun 28, 2023
@samkim-crypto samkim-crypto deleted the zk-token-sdk/sigma_proof_docs branch June 28, 2023 00:55
mergify bot pushed a commit that referenced this pull request Jun 28, 2023
…w fee sigma proof is computed (#32288)

* function docs to focus on the action they perform

* update docs for fee sigma proof

* add link to zk token proof doc

* Apply suggestions from code review

Co-authored-by: Tyera <[email protected]>

---------

Co-authored-by: Tyera <[email protected]>
(cherry picked from commit 5624aaa)
samkim-crypto added a commit that referenced this pull request Jun 28, 2023
…n of how fee sigma proof is computed (backport of #32288) (#32302)

[zk-token-sdk](docs) Update docs to include a brief description of how fee sigma proof is computed (#32288)

* function docs to focus on the action they perform

* update docs for fee sigma proof

* add link to zk token proof doc

* Apply suggestions from code review

Co-authored-by: Tyera <[email protected]>

---------

Co-authored-by: Tyera <[email protected]>
(cherry picked from commit 5624aaa)

Co-authored-by: samkim-crypto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.16 PRs that should be backported to v1.16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants