-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zk-token-sdk](docs) Update docs to include a brief description of how fee sigma proof is computed #32288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
changed the title
[zk-token-sdk(docs-only)] Update docs to include a brief description of how fee sigma proof is computed
[zk-token-sdk](docs) Update docs to include a brief description of how fee sigma proof is computed
Jun 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #32288 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 772 772
Lines 209538 209480 -58
=========================================
- Hits 171973 171900 -73
- Misses 37565 37580 +15 |
samkim-crypto
force-pushed
the
zk-token-sdk/sigma_proof_docs
branch
from
June 27, 2023 06:57
d9f0366
to
89379b8
Compare
samkim-crypto
added
v1.16
PRs that should be backported to v1.16
and removed
work in progress
This isn't quite right yet
labels
Jun 27, 2023
zk-token-sdk/src/sigma_proofs/ciphertext_ciphertext_equality_proof.rs
Outdated
Show resolved
Hide resolved
samkim-crypto
force-pushed
the
zk-token-sdk/sigma_proof_docs
branch
from
June 28, 2023 00:00
301a844
to
e744be9
Compare
CriesofCarrots
approved these changes
Jun 28, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
…w fee sigma proof is computed (#32288) * function docs to focus on the action they perform * update docs for fee sigma proof * add link to zk token proof doc * Apply suggestions from code review Co-authored-by: Tyera <[email protected]> --------- Co-authored-by: Tyera <[email protected]> (cherry picked from commit 5624aaa)
samkim-crypto
added a commit
that referenced
this pull request
Jun 28, 2023
…n of how fee sigma proof is computed (backport of #32288) (#32302) [zk-token-sdk](docs) Update docs to include a brief description of how fee sigma proof is computed (#32288) * function docs to focus on the action they perform * update docs for fee sigma proof * add link to zk token proof doc * Apply suggestions from code review Co-authored-by: Tyera <[email protected]> --------- Co-authored-by: Tyera <[email protected]> (cherry picked from commit 5624aaa) Co-authored-by: samkim-crypto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The docs in the
sigma_proofs
module could be added/improved.Summary of Changes
new
andverify
function docs with respect to the actions they take (follow-up to [zk-token-sdk] Refactor ciphertext validity sigma proof and renameValidityProof
toGroupedCiphertextValidityProof
#32040 (comment)).This PR touches docs only.
Fixes #