[zk-token-sdk] Refactor ciphertext validity sigma proof and rename ValidityProof to GroupedCiphertextValidityProof
#32040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
added
work in progress
Codecov Report
@@ Coverage Diff @@
## master #32040 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 764 765 +1
Lines 208095 208095
=========================================
- Hits 170500 170496 -4
- Misses 37595 37599 +4 |
zk-token-sdk/src/sigma_proofs/grouped_ciphertext_validity_proof.rs
Outdated
Show resolved
Hide resolved
| /// Append a domain separator for validity proof. | ||
| fn validity_proof_domain_sep(&mut self); | ||
| /// Append a domain separator for grouped ciphertext validity proof. | ||
| fn grouped_ciphertext_validity_proof_domain_sep(&mut self); |
There was a problem hiding this comment.
Would be nice to spell out separator, in a separate PR
There was a problem hiding this comment.
Yep, sounds good! Will do!
zk-token-sdk/src/sigma_proofs/batched_grouped_ciphertext_validity_proof.rs
Outdated
Show resolved
Hide resolved
…ity_proof.rs Co-authored-by: Tyera <[email protected]>
…f.rs Co-authored-by: Tyera <[email protected]>
CriesofCarrots
approved these changes
Jun 13, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…alidityProof` to `GroupedCiphertextValidityProof` (#32040) * rename `CiphertextValidityProof` to `GroupedCiphertext2HandlesValidityProof` * rename `AggregatedValidityProof` to `BatchedGroupedCiphertext2HandlesValidityProof` * refactor `validity_proof` module into separate modules * update test names * update `aggregated` variable names * update transcript function names * Update zk-token-sdk/src/sigma_proofs/batched_grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Update zk-token-sdk/src/sigma_proofs/grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Reword constructor docs --------- Co-authored-by: Tyera <[email protected]> (cherry picked from commit 84e28c2)
jeffwashington
pushed a commit
to HaoranYi/solana
that referenced
this pull request
Jun 13, 2023
…alidityProof` to `GroupedCiphertextValidityProof` (solana-labs#32040) * rename `CiphertextValidityProof` to `GroupedCiphertext2HandlesValidityProof` * rename `AggregatedValidityProof` to `BatchedGroupedCiphertext2HandlesValidityProof` * refactor `validity_proof` module into separate modules * update test names * update `aggregated` variable names * update transcript function names * Update zk-token-sdk/src/sigma_proofs/batched_grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Update zk-token-sdk/src/sigma_proofs/grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Reword constructor docs --------- Co-authored-by: Tyera <[email protected]>
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…alidityProof` to `GroupedCiphertextValidityProof` (solana-labs#32040) * rename `CiphertextValidityProof` to `GroupedCiphertext2HandlesValidityProof` * rename `AggregatedValidityProof` to `BatchedGroupedCiphertext2HandlesValidityProof` * refactor `validity_proof` module into separate modules * update test names * update `aggregated` variable names * update transcript function names * Update zk-token-sdk/src/sigma_proofs/batched_grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Update zk-token-sdk/src/sigma_proofs/grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Reword constructor docs --------- Co-authored-by: Tyera <[email protected]>
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…alidityProof` to `GroupedCiphertextValidityProof` (solana-labs#32040) * rename `CiphertextValidityProof` to `GroupedCiphertext2HandlesValidityProof` * rename `AggregatedValidityProof` to `BatchedGroupedCiphertext2HandlesValidityProof` * refactor `validity_proof` module into separate modules * update test names * update `aggregated` variable names * update transcript function names * Update zk-token-sdk/src/sigma_proofs/batched_grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Update zk-token-sdk/src/sigma_proofs/grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Reword constructor docs --------- Co-authored-by: Tyera <[email protected]>
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…alidityProof` to `GroupedCiphertextValidityProof` (solana-labs#32040) * rename `CiphertextValidityProof` to `GroupedCiphertext2HandlesValidityProof` * rename `AggregatedValidityProof` to `BatchedGroupedCiphertext2HandlesValidityProof` * refactor `validity_proof` module into separate modules * update test names * update `aggregated` variable names * update transcript function names * Update zk-token-sdk/src/sigma_proofs/batched_grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Update zk-token-sdk/src/sigma_proofs/grouped_ciphertext_validity_proof.rs Co-authored-by: Tyera <[email protected]> * Reword constructor docs --------- Co-authored-by: Tyera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The instructions
VerifyGroupedCiphertext2HandlesValidityandVerifyBatchedGroupedCiphertext2HandlesValidityhave been added to the proof program (#31816). The actual sigma proofs that are used as proof data for these instructions are namedValidityProofandAggregatedValidityProof, which doesn't quite match with the proof program instructions.Summary of Changes
ValidityProoftoGroupedCiphertext2HandlesValidityProofAggregatedValidityProoftoBatchedGroupedCiphertext2HandlesValidityProofFixes #