Relax gossip to banking stage filtering to allow refreshed votes #31879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
force-pushed
the
refresh-votes-gossip
branch
from
e71ca56 to
393e005
Compare
AshwinSekar
commented
May 30, 2023
AshwinSekar
force-pushed
the
refresh-votes-gossip
branch
2 times, most recently
from
b70d380 to
fe9ba09
Compare
AshwinSekar
force-pushed
the
refresh-votes-gossip
branch
2 times, most recently
from
effb3bb to
6354df6
Compare
Codecov Report
@@ Coverage Diff @@
## master #31879 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 757 755 -2
Lines 206984 207057 +73
=======================================
+ Hits 169543 169620 +77
+ Misses 37441 37437 -4 |
t-nelson
reviewed
May 31, 2023
AshwinSekar
force-pushed
the
refresh-votes-gossip
branch
3 times, most recently
from
a511a43 to
800f5b6
Compare
carllin
previously approved these changes
May 31, 2023
core/src/verified_vote_packets.rs
Outdated
| @@ -185,6 +187,13 @@ impl SingleValidatorVotes { | |||
| } | |||
| } | |||
|
|
|||
| fn get_latest_gossip_timestamp(&self) -> Option<UnixTimestamp> { | |||
There was a problem hiding this comment.
nit: think we can just name this to get_timestamp, since it's not necessarily from gossip
core/src/verified_vote_packets.rs
Outdated
| assert_eq!(slot, vote_later_ts.last_voted_slot().unwrap()); | ||
| assert_eq!(timestamp, vote_later_ts.timestamp); | ||
|
|
||
| // Same vote with no ts should not override |
There was a problem hiding this comment.
nit, spell out ts to timestamp
core/src/verified_vote_packets.rs
Outdated
| assert_eq!(slot, vote_later_ts.last_voted_slot().unwrap()); | ||
| assert_eq!(timestamp, vote_later_ts.timestamp); | ||
|
|
||
| // Same vote with earlier ts should not override |
There was a problem hiding this comment.
nit: expand ts to timestamp
AshwinSekar
dismissed stale reviews from carllin, steviez, and t-nelson
via
be5c1b0
AshwinSekar
force-pushed
the
refresh-votes-gossip
branch
from
800f5b6 to
be5c1b0
Compare
carllin
approved these changes
May 31, 2023
bw-solana
approved these changes
May 31, 2023
AshwinSekar
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
May 31, 2023
) (cherry picked from commit 1b79875)
AshwinSekar
added a commit
that referenced
this pull request
Jun 1, 2023
) (cherry picked from commit 1b79875)
AshwinSekar
added a commit
that referenced
this pull request
Jun 1, 2023
) (cherry picked from commit 1b79875)
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
) (cherry picked from commit 1b79875)
AshwinSekar
added a commit
that referenced
this pull request
Jun 1, 2023
…es (backport of #31879) (#31907) Relax gossip to banking stage filtering to allow refreshed votes (#31879) (cherry picked from commit 1b79875) Co-authored-by: Ashwin Sekar <[email protected]>
AshwinSekar
added a commit
that referenced
this pull request
Jun 1, 2023
…es (backport of #31879) (#31906) Relax gossip to banking stage filtering to allow refreshed votes (#31879) (cherry picked from commit 1b79875) Co-authored-by: Ashwin Sekar <[email protected]>
This was referenced Jun 1, 2023
bw-solana
pushed a commit
to bw-solana/solana
that referenced
this pull request
Jan 10, 2025
…es (backport of solana-labs#31879) (solana-labs#31906) Relax gossip to banking stage filtering to allow refreshed votes (solana-labs#31879) (cherry picked from commit 1b79875) Co-authored-by: Ashwin Sekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The feature flag
allow_votes_to_directly_update_vote_stateallows an optimization of only storing one vote per validator before forwarding to banking stage. We store votes for the latest slot - which implicitly drops refreshed votes.Summary of Changes
Create a tiebreaker, if the slot is the same as the latest vote only accept it if it has a later timestamp (refreshed vote)
Fixes #