v1.14: Relax gossip to banking stage filtering to allow refreshed votes (backport of #31879) #31906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
AshwinSekar
force-pushed
the
mergify/bp/v1.14/pr-31879
branch
from
fd9c2e7 to
c8fe37d
Compare
) (cherry picked from commit 1b79875)
AshwinSekar
force-pushed
the
mergify/bp/v1.14/pr-31879
branch
from
c8fe37d to
769f7e1
Compare
Codecov Report
@@ Coverage Diff @@
## v1.14 #31906 +/- ##
========================================
Coverage 82.1% 82.1%
========================================
Files 665 665
Lines 185294 185368 +74
========================================
+ Hits 152204 152308 +104
+ Misses 33090 33060 -30 |
steviez
approved these changes
Jun 1, 2023
Comment on lines
+244
to
+247
|
|
||
| pub fn last_voted_slot(&self) -> Option<Slot> { | ||
| self.lockouts.back().map(|l| l.slot) | ||
| } |
There was a problem hiding this comment.
For sake of paper trail, this was the extra bit needed for v1.14 BP in comparison to original PR
bw-solana
pushed a commit
to bw-solana/solana
that referenced
this pull request
Jan 10, 2025
…es (backport of solana-labs#31879) (solana-labs#31906) Relax gossip to banking stage filtering to allow refreshed votes (solana-labs#31879) (cherry picked from commit 1b79875) Co-authored-by: Ashwin Sekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #31879 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com