Use timestamp to tiebreak votes in banking_stage #31925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
force-pushed
the
refresh-votes-banking
branch
from
814cfbe to
39e576d
Compare
tao-stones
reviewed
Jun 2, 2023
carllin
previously approved these changes
Jun 3, 2023
core/src/latest_unprocessed_votes.rs
Outdated
Comment on lines
209
to
210
| let latest_slot = latest_vote.read().unwrap().slot(); | ||
| if slot > latest_slot { | ||
| let latest_timestamp = latest_vote.read().unwrap().timestamp; |
There was a problem hiding this comment.
think we can just take the lock once and grab both these fields
AshwinSekar
force-pushed
the
refresh-votes-banking
branch
from
39e576d to
a59357e
Compare
Codecov Report
@@ Coverage Diff @@
## master #31925 +/- ##
========================================
Coverage 81.9% 81.9%
========================================
Files 760 760
Lines 207407 207513 +106
========================================
+ Hits 169968 170070 +102
- Misses 37439 37443 +4 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
(cherry picked from commit 9f62cc1)
AshwinSekar
added a commit
that referenced
this pull request
Jun 5, 2023
…31925) (#31973) Use timestamp to tiebreak votes in banking_stage (#31925) (cherry picked from commit 9f62cc1) Co-authored-by: Ashwin Sekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Refreshed votes are dropped as the deduplication logic doesn't allow new votes for the same slot to entire the queue.
Same bug as #31879 further in the pipeline in banking_stage. This affects both tpu and gossip votes.
Summary of Changes
Allow refreshed votes in banking stage queue by using timestamp to tiebreak.
Note: only affects v1.16.0+ with the
allow_votes_to_directly_update_vote_statefeature enabled.Fixes #