Cleanup - mock InvokeContext #31007
Merged
Cleanup - mock InvokeContext #31007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
cleanup/mock_invoke_context
branch
9 times, most recently
from
c6ae3ea to
f1ee7e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #31007 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 728 728
Lines 205499 205503 +4
=========================================
- Hits 167599 167584 -15
- Misses 37900 37919 +19 |
Lichtso
force-pushed
the
cleanup/mock_invoke_context
branch
2 times, most recently
from
22bcb6f to
a646eae
Compare
Lichtso
force-pushed
the
cleanup/mock_invoke_context
branch
from
a646eae to
746f0b1
Compare
pgarg66
approved these changes
Apr 3, 2023
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 3, 2023
* Turns with_mock_invoke_context() into a macro. * Removes prepare_mock_invoke_context(). * Replaces InvokeContext::new_mock() with with_mock_invoke_context(). * Removes InvokeContext::new_mock(). * Removes Cow from InvokeContext::sysvar_cache. * Removes override parameters from mock_process_instruction(). * cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
InvokeContext::new_mock()should not be used externally as it has references to some internals which tend to create messy lifetimes.Summary of Changes
with_mock_invoke_context()into a macro.prepare_mock_invoke_context().InvokeContext::new_mock()withwith_mock_invoke_context().mock_process_instruction().InvokeContext::sysvar_cache.