Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test code #33247

Merged

Conversation

CriesofCarrots
Copy link
Contributor

Problem

#31007 removed overrides from mock_process_instruction(), but a stake-redelegate test still has a sysvar cache override block. This is because it is mutable and mutated, so doesn't alert the compiler that it is unused.
The lingering block is confusing to people reading this test to understand how to handle sysvars in stake tests.

Summary of Changes

Remove unused block

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #33247 (92c61fd) into master (602f0f6) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #33247     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         790      790             
  Lines      214214   214208      -6     
=========================================
- Hits       175585   175562     -23     
- Misses      38629    38646     +17     

@CriesofCarrots CriesofCarrots merged commit 1e1e296 into solana-labs:master Sep 14, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants