cli: fix program deployment elf verification issue

[ananas-block]

Problem

Deployment of solana programs using the alt bn128 syscall fails with cli versions 1.16.*, with the following error:

Error: ELF error: ELF error: Unresolved symbol (sol_alt_bn128_group_op) at instruction #16736 (ELF file offset 0x20a18

See this example for steps to replicate the issue:
https://github.com/ananas-block/exec_test/tree/altbn_deploy

Summary of Changes

• replaces FeatureSet::default() with FeatureSet::all_enabled()

Fixes #
#32447

[joncinque]

It looks like this was modified in #31007 -- while default is certainly overly restrictive, I don't think all_enabled is the right option, since one of the reasons for the check is to make sure that you're not trying to use a syscall that hasn't been enabled yet.

I'm thinking the best option is to build the current feature set, similar to

solana/cli/src/feature.rs

Lines 802 to 835 in dd75d09

	let mut features = vec![];
	for feature_ids in feature_ids.chunks(MAX_MULTIPLE_ACCOUNTS) {
	let mut feature_chunk = rpc_client
	.get_multiple_accounts(feature_ids)
	.unwrap_or_default()
	.into_iter()
	.zip(feature_ids)
	.map(|(account, feature_id)| {
	let feature_name = FEATURE_NAMES.get(feature_id).unwrap();
	account
	.and_then(status_from_account)
	.map(|feature_status| CliFeature {
	id: feature_id.to_string(),
	description: feature_name.to_string(),
	status: feature_status,
	})
	.unwrap_or_else(|| {
	inactive = true;
	CliFeature {
	id: feature_id.to_string(),
	description: feature_name.to_string(),
	status: CliFeatureStatus::Inactive,
	}
	})
	})
	.filter(|feature| match (filter, &feature.status) {
	(Some(min_activation), CliFeatureStatus::Active(activation)) => {
	activation > &min_activation
	}
	_ => true,
	})
	.collect::<Vec<_>>();
	features.append(&mut feature_chunk);
	}

, and then pass that in.

@Lichtso what do you think? Since you made the FeatureSet::default() change, maybe you'll have a good idea about how to improve this.

[Lichtso]

We could fetch the feature set from the network, but it would not change much I think. The loader program on the network verifies the deployment anyway. I am fine with switching it back to FeatureSet::all_enabled().

[joncinque]

In that case, how about we create an issue to do this correctly, but merge this + backport to unblock people?

[codecov]

Codecov Report

Merging #32448 (d4526a7) into master (3fa3d26) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #32448   +/-   ##
=======================================
  Coverage    82.1%    82.1%           
=======================================
  Files         778      778           
  Lines      210051   210051           
=======================================
+ Hits       172529   172565   +36     
+ Misses      37522    37486   -36