Plumb maximum_incremental_snapshot_archives_to_retain
#19640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
plumb-maximum_incremental_snapshot_archives_to_retain
branch
from
d7c969e to
e956379
Compare
brooksprumo
force-pushed
the
plumb-maximum_incremental_snapshot_archives_to_retain
branch
from
e956379 to
316881d
Compare
Codecov Report
@@ Coverage Diff @@
## master #19640 +/- ##
=======================================
Coverage 82.5% 82.5%
=======================================
Files 468 468
Lines 131896 131901 +5
=======================================
+ Hits 108885 108892 +7
+ Misses 23011 23009 -2 |
brooksprumo
deleted the
plumb-maximum_incremental_snapshot_archives_to_retain
branch
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…na-labs#19640)" This reverts commit 9e606be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
purge_old_snapshot_archives()could accept amaximum_incremental_snapshot_archives_to_retainparameter, but no functions could set that parameter with anything other than the default, since it was not plumbed through.Summary of Changes
Plumb through
maximum_incremental_snapshot_archives_to_retainThis is the final PR for this work. See also:
PR #19612
PR #19615
PR #19616
And the main issue: #18639