Pass SnapshotConfig to SnapshotPackagerService #19616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #19616 +/- ##
=========================================
- Coverage 82.7% 82.5% -0.2%
=========================================
Files 461 468 +7
Lines 131215 131677 +462
=========================================
+ Hits 108519 108651 +132
- Misses 22696 23026 +330 |
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SnapshotPackagerService will need more values that are from SnapshotConfig for incremental snapshot support. Instead of just passing in each one-by-one everywhere, gimme the whole SnapshotConfig to make life easier.