Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum_incremental_snapshot_archives_to_retain to SnapshotConfig #19612

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Sep 3, 2021

Adding maximum_incremental_snapshot_archives_to_retain into SnapshotConfig has a good bit of plumbing noise, so pulled it out into its own PR.

The maximum_incremental_snapshot_archives_to_retain will be used by many functions in snapshot_utils.

@brooksprumo brooksprumo marked this pull request as ready for review September 3, 2021 18:18
Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo added the automerge Merge this Pull Request automatically once CI passes label Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #19612 (65ed8db) into master (c550b32) will decrease coverage by 0.1%.
The diff coverage is 41.3%.

@@            Coverage Diff            @@
##           master   #19612     +/-   ##
=========================================
- Coverage    82.7%    82.5%   -0.2%     
=========================================
  Files         461      468      +7     
  Lines      131215   131677    +462     
=========================================
+ Hits       108519   108675    +156     
- Misses      22696    23002    +306     

@mergify mergify bot merged commit 5e25ee5 into solana-labs:master Sep 3, 2021
@brooksprumo brooksprumo deleted the snapshot-config branch September 3, 2021 20:22
frits-metalogix added a commit to identity-com/solana that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants