Introduce common base class MNASimPowerComp - deprecated #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JTS22
force-pushed
the
mnasimpowercomp
branch
from
a8a0b75
to
fc40703
Compare
JTS22
force-pushed
the
mnasimpowercomp
branch
2 times, most recently
from
2dc5b0f
to
b929960
Compare
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
JTS22
force-pushed
the
mnasimpowercomp
branch
from
c566a09
to
e64fc5d
Compare
|
SonarCloud Quality Gate failed. |
m-mirz
added a commit
that referenced
this pull request
Jan 22, 2023
Introduces two new base classes, MNASimPowerComp<T> and CompositePowerComp<T>. For all composite components (as defined in #131), MNASimPowerComp provides default implementations for all methods in MNAInterface, as well as default MnaPreStep and MnaPostStep tasks, such that MNAInterface is only inherited once in the parent class and not in each component individually. Additionally, CompositePowerComp provides mnaParent... methods for most of the MNA methods in MNAInterface. Via the addMNASubComponent method, a component can register subcomponents for which the relevant MNA methods are called automatically by the CompositePowerComp parent class. For each MNA method, the child component class can decide to either override the normal mna... method and provide subcomponent handling themselves, or override just the mnaParent... method and let the subcomponents (and some other common operations) get handled by the parent class methods. While the MNASimPowerComp class is not used for any non-composite components in this PR, the unification of MNA methods for these components is covered in #150 . Based on #142 Related to #131 Rebase of #144
dinkelbachjan
changed the title
dinkelbachjan
added a commit
that referenced
this pull request
Feb 21, 2023
Unifies the behavior of all components that previously implemented MNAInterface by providing a common base class MNASimPowerComp<T>. This base class implements MNAInterface and all its methods in such a way, that common actions such as the creation and registration of the pre- and post-step tasks are done uniformly in the base class. The various mna... methods are replaced by a new set of mnaComp... methods that can be implemented by the child component classes to provide their own MNA behavior. Based on #144 Rebase of #150
|
Closing, since this has been replaced by #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies the behavior of all components that previously implemented
MNAInterfaceby providing a common base classMNASimPowerComp<T>. This base class implementsMNAInterfaceand all its methods in such a way, that common actions such as the creation and registration of the pre- and post-step tasks are done uniformly in the base class. The variousmna...methods are replaced by a new set ofmnaComp...methods that can be implemented by the child component classes to provide their own MNA behavior.Based on #144