-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce common base class MNASimPowerComp #178
Conversation
@dinkelbachjan @martinmoraga This is the rebase of Jonas' last PR. Some changes conflict with Martin's #120. I've already rebased on the current master but I am fixing this based on https://github.com/sogno-platform/dpsim/pull/120/files and https://github.com/sogno-platform/dpsim/pull/150/files |
a28dbc3
to
ba19ec7
Compare
done! |
@martinmoraga Perfect. Thanks! |
dpsim-models/include/dpsim-models/DP/DP_Ph1_ReducedOrderSynchronGeneratorVBR.h
Show resolved
Hide resolved
dpsim-models/include/dpsim-models/EMT/EMT_Ph3_ReducedOrderSynchronGeneratorVBR.h
Outdated
Show resolved
Hide resolved
dpsim-models/include/dpsim-models/SP/SP_Ph1_ReducedOrderSynchronGeneratorVBR.h
Outdated
Show resolved
Hide resolved
dpsim-models/include/dpsim-models/SP/SP_Ph1_SynchronGenerator4OrderDCIM.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Markus Mirz <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
985cb58
to
eea0f2f
Compare
SonarCloud Quality Gate failed. |
Unifies the behavior of all components that previously implemented MNAInterface by providing a common base class MNASimPowerComp. This base class implements MNAInterface and all its methods in such a way, that common actions such as the creation and registration of the pre- and post-step tasks are done uniformly in the base class. The various mna... methods are replaced by a new set of mnaComp... methods that can be implemented by the child component classes to provide their own MNA behavior.
Based on #144
Rebase of #150