Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce common base class MNASimPowerComp #178

Merged
merged 18 commits into from
Feb 21, 2023

Conversation

m-mirz
Copy link
Contributor

@m-mirz m-mirz commented Jan 22, 2023

Unifies the behavior of all components that previously implemented MNAInterface by providing a common base class MNASimPowerComp. This base class implements MNAInterface and all its methods in such a way, that common actions such as the creation and registration of the pre- and post-step tasks are done uniformly in the base class. The various mna... methods are replaced by a new set of mnaComp... methods that can be implemented by the child component classes to provide their own MNA behavior.

Based on #144

Rebase of #150

@m-mirz
Copy link
Contributor Author

m-mirz commented Jan 22, 2023

@dinkelbachjan @martinmoraga This is the rebase of Jonas' last PR. Some changes conflict with Martin's #120. I've already rebased on the current master but Base_ReducedOrderSynchronGenerator and maybe 1-2 other generator classes got messed up.

I am fixing this based on https://github.com/sogno-platform/dpsim/pull/120/files and https://github.com/sogno-platform/dpsim/pull/150/files

@martinmoraga
Copy link
Contributor

@dinkelbachjan @martinmoraga This is the rebase of Jonas' last PR. Some changes conflict with Martin's #120. I've already rebased on the current master but Base_ReducedOrderSynchronGenerator and maybe 1-2 other generator classes got messed up.

I am fixing this based on https://github.com/sogno-platform/dpsim/pull/120/files and https://github.com/sogno-platform/dpsim/pull/150/files

@m-mirz @dinkelbachjan

done!

@m-mirz
Copy link
Contributor Author

m-mirz commented Jan 29, 2023

@martinmoraga Perfect. Thanks!

@dinkelbachjan dinkelbachjan self-assigned this Feb 1, 2023
JTS22 and others added 18 commits February 21, 2023 15:41
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Markus Mirz <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 260 Code Smells

0.0% 0.0% Coverage
12.3% 12.3% Duplication

@dinkelbachjan dinkelbachjan changed the title Introduce common base class MNASimPowerComp - rebased Introduce common base class MNASimPowerComp Feb 21, 2023
@dinkelbachjan dinkelbachjan merged commit 08604af into master Feb 21, 2023
@dinkelbachjan dinkelbachjan deleted the mnasimpowercomp-rebased branch March 6, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants