Resolve FIXME comments #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
3 tasks
JTS22
force-pushed
the
fix-fixmes
branch
2 times, most recently
from
b920b36
to
18e0a37
Compare
m-mirz
previously approved these changes
Jan 8, 2023
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
Signed-off-by: Jonas Schroeder <[email protected]>
m-mirz
approved these changes
Jan 9, 2023
|
Kudos, SonarCloud Quality Gate passed! |
m-mirz
added a commit
that referenced
this pull request
Jan 22, 2023
Introduces two new base classes, MNASimPowerComp<T> and CompositePowerComp<T>. For all composite components (as defined in #131), MNASimPowerComp provides default implementations for all methods in MNAInterface, as well as default MnaPreStep and MnaPostStep tasks, such that MNAInterface is only inherited once in the parent class and not in each component individually. Additionally, CompositePowerComp provides mnaParent... methods for most of the MNA methods in MNAInterface. Via the addMNASubComponent method, a component can register subcomponents for which the relevant MNA methods are called automatically by the CompositePowerComp parent class. For each MNA method, the child component class can decide to either override the normal mna... method and provide subcomponent handling themselves, or override just the mnaParent... method and let the subcomponents (and some other common operations) get handled by the parent class methods. While the MNASimPowerComp class is not used for any non-composite components in this PR, the unification of MNA methods for these components is covered in #150 . Based on #142 Related to #131 Rebase of #144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves many of the FIXME comments spread throughout the code. The main changes are:
attribute<T>method inAttributeListtoattributeTyped<T>to avoid overlap with the method returning anAttributeBase::PtrBased on #141
Related to #132