Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling and invoking contracts through dispatchers #2144

Merged
merged 26 commits into from
Jun 30, 2023
Merged

Calling and invoking contracts through dispatchers #2144

merged 26 commits into from
Jun 30, 2023

Conversation

cptartur
Copy link
Member

@cptartur cptartur commented Jun 28, 2023 •
edited
Loading

Closes #1992

This PR also fixes some parts of the declare and deploy cheatcodes logic.

Checklist

  • Relevant issue is linked
  • Docs updated/issue for docs created
  • Added relevant tests

@cptartur cptartur changed the title 1992 contract calling Calling and invoking contracts through dispatchers Jun 29, 2023
@cptartur cptartur marked this pull request as ready for review June 29, 2023 10:29
@cptartur cptartur requested a review from a team as a code owner June 29, 2023 10:29
@cptartur cptartur requested review from Radinyn, piotmag769 and Arcticae and removed request for a team June 29, 2023 10:29
Arcticae
Arcticae approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although i'd ask somebody for best rust practises 😅

protostar-rust/src/cheatcodes_hint_processor.rs Show resolved Hide resolved
protostar-rust/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
protostar-rust/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
protostar-rust/src/cheatcodes_hint_processor.rs Show resolved Hide resolved
protostar-rust/tests/data/dispatchers/tests/using_dispatchers.cairo Outdated Show resolved Hide resolved
@cptartur cptartur force-pushed the 1992-contract-calling branch from 56b93d2 to 6954c24 Compare June 29, 2023 13:43
Base automatically changed from 1847-multiple-contracts-in-package to master June 29, 2023 13:59
@cptartur cptartur force-pushed the 1992-contract-calling branch from 6954c24 to 2889752 Compare June 29, 2023 14:20
piotmag769
piotmag769 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know the PR handling failure/panic data is being done on the base of this PR, that's why I requested changes before

@cptartur cptartur mentioned this pull request Jun 30, 2023
Closed
3 tasks
@github-actions github-actions bot added size/XL and removed size/L labels Jun 30, 2023
@cptartur cptartur mentioned this pull request Jun 30, 2023
Closed
@cptartur
Copy link
Member Author

Created these issues as followup for this PR:

#2156
#2158

@cptartur cptartur enabled auto-merge June 30, 2023 13:26
@cptartur cptartur added this pull request to the merge queue Jun 30, 2023
Merged via the queue into master with commit 6eebb27 Jun 30, 2023
@cptartur cptartur deleted the 1992-contract-calling branch June 30, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

@Radinyn Radinyn Awaiting requested review from Radinyn Radinyn is a code owner automatically assigned from software-mansion/protostar

Assignees

@cptartur cptartur

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract calling
3 participants
@cptartur @Arcticae @piotmag769