Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract calling #1992

Closed
karol-bisztyga opened this issue May 26, 2023 · 5 comments · Fixed by #2144
Closed

Contract calling #1992

karol-bisztyga opened this issue May 26, 2023 · 5 comments · Fixed by #2144
Assignees
@cptartur
Labels
asap This task blocks/conflicts with another tasks or is very important
Milestone
Rust test runner

Comments

@karol-bisztyga
Copy link
Contributor

karol-bisztyga commented May 26, 2023 •
edited by MaksymilianDemitraszek
Loading

We should implement contract call syscall to use blockifier instead

test {
let address = ContractADispatcher::deploy(args, to, constructor);

let contract = ContractADispatcher { address: address };
contract.get_balance(user_id);
}
@karol-bisztyga karol-bisztyga added this to the Rust test runner milestone May 26, 2023
@karol-bisztyga karol-bisztyga added the asap This task blocks/conflicts with another tasks or is very important label May 26, 2023
@MaksymilianDemitraszek
Copy link
Contributor

MaksymilianDemitraszek commented Jun 15, 2023 •
edited
Loading

#1988 (comment) probably should be closed due to the reason mentioned there

@MaksymilianDemitraszek
Copy link
Contributor

MaksymilianDemitraszek commented Jun 15, 2023 •
edited
Loading 

test {
let address = ContractADispatcher::deploy(args, to, constructor);

let contract = ContractADispatcher { address: address };
contract.get_balance(user_id);
}

we can override contract call syscall

@MaksymilianDemitraszek MaksymilianDemitraszek changed the title Implement Call cheat code in rust Contract calling Jun 15, 2023
@MaksymilianDemitraszek
Copy link
Contributor

Blocked by #2080

@MaksymilianDemitraszek MaksymilianDemitraszek added blocked asap This task blocks/conflicts with another tasks or is very important and removed asap This task blocks/conflicts with another tasks or is very important blocked labels Jun 15, 2023
@MaksymilianDemitraszek
Copy link
Contributor

We can use test set created in #2099

@cptartur
Copy link
Member

Blocked by problem with nonces when making consecutive transactions

@cptartur cptartur self-assigned this Jun 27, 2023
@cptartur cptartur removed the blocked label Jun 28, 2023
@cptartur cptartur mentioned this issue Jun 28, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 30, 2023
@cptartur
Calling and invoking contracts through dispatchers (#2144)
6eebb27 
Closes #1992 

This PR also fixes some parts of the declare and deploy cheatcodes
logic.

### Checklist
- [ ] Relevant issue is linked
- [ ] Docs updated/issue for docs created
- [ ] Added relevant tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cptartur cptartur

Labels
asap This task blocks/conflicts with another tasks or is very important
Projects
None yet
Milestone
Rust test runner
Development

Successfully merging a pull request may close this issue.

Calling and invoking contracts through dispatchers software-mansion/protostar
3 participants
@MaksymilianDemitraszek @cptartur @karol-bisztyga