Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a PR to cairo repo to change MemBuffer visibility to public #2158

Closed
cptartur opened this issue Jun 30, 2023 · 2 comments
Closed

Make a PR to cairo repo to change MemBuffer visibility to public #2158

cptartur opened this issue Jun 30, 2023 · 2 comments
Assignees
@abulenok
Labels
cairo-compiler This includes downstreaming changes to cairo compiler
Milestone
Rust test runner

Comments

@cptartur
Copy link
Member

cptartur commented Jun 30, 2023 •
edited
Loading

From: #2144 (comment)

MemBuffer from cairo repo https://github.com/starkware-libs/cairo/blob/main/crates/cairo-lang-runner/src/casm_run/mod.rs#L394 should have it visibility changed to public so it can be used in our cheatcode hint processor.
@cptartur cptartur added this to the Rust test runner milestone Jun 30, 2023
@cptartur cptartur mentioned this issue Jun 30, 2023
Merged
3 tasks
@abulenok abulenok self-assigned this Jul 3, 2023
@MaksymilianDemitraszek MaksymilianDemitraszek added the cairo-compiler This includes downstreaming changes to cairo compiler label Jul 3, 2023
@abulenok
Copy link
Contributor

abulenok commented Jul 4, 2023 •
edited
Loading

cairo-compiler PR

starkware-libs/cairo#3588

@abulenok
Copy link
Contributor

abulenok commented Jul 5, 2023

related #2164

@abulenok abulenok closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abulenok abulenok

Labels
cairo-compiler This includes downstreaming changes to cairo compiler
Projects
None yet
Milestone
Rust test runner
Development

No branches or pull requests
3 participants
@MaksymilianDemitraszek @cptartur @abulenok