Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.0.0 #89

Merged
merged 12 commits into from
Nov 6, 2019
Merged

Release/1.0.0 #89

merged 12 commits into from
Nov 6, 2019

Conversation

aldemirenes
Copy link
Contributor

@aldemirenes aldemirenes commented Aug 19, 2019 •
edited
Loading

Instructions for integrating ScalaDoc-GhPages can be found in here.

@aldemirenes aldemirenes mentioned this pull request Aug 19, 2019
Closed
@aldemirenes
Copy link
Contributor Author

I've realized some problem with scoverage. It causes NoDefFoundError while trying to use library. I've made some research but couldn't find a definite answer. Error can be generated with publishing library local with +publishLocal command and trying to use it. Some related link can be found in here.

@aldemirenes aldemirenes mentioned this pull request Sep 13, 2019
Closed
@benjben
Copy link
Contributor

benjben commented Oct 17, 2019 •
edited
Loading

Something is wrong with scoverage. When publishing this lib through Travis, and using it in a project, it fails with the error : Caused by: java.io.FileNotFoundException: /home/travis/build/snowplow/snowplow-scala-analytics-sdk/target/scala-2.12/scoverage-data/scoverage.measurements.85 (No such file or directory) This page should help.

@benjben benjben force-pushed the release/1.0.0 branch 2 times, most recently from 96ac4f9 to 1eb3a3c Compare October 17, 2019 13:59
dilyand
dilyand suggested changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@dilyand dilyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go over the issues I uncovered in my review but it would be great to have another reviewer in the meantime as well. @chuwy perhaps?

src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/Event.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/Event.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/SnowplowEvent.scala Show resolved Hide resolved
src/test/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/EventSpec.scala Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@dilyand dilyand requested a review from chuwy November 1, 2019 16:39
chuwy
chuwy reviewed Nov 4, 2019
View reviewed changes
Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of comments are minor, but ScalaDoc website is strictly necessary for 1.0.0.

src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/Event.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
src/test/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/EventSpec.scala Outdated Show resolved Hide resolved
src/test/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/EventSpec.scala Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/SnowplowEvent.scala Outdated Show resolved Hide resolved
@dilyand dilyand force-pushed the release/1.0.0 branch 6 times, most recently from d8b2d87 to 94640a5 Compare November 4, 2019 15:20
@dilyand
Copy link
Contributor

dilyand commented Nov 4, 2019 •
edited
Loading

To do:

@dilyand dilyand force-pushed the release/1.0.0 branch 3 times, most recently from 6a61c6f to f02cbd3 Compare November 6, 2019 08:55
chuwy
chuwy approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just few questions.

README.md Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/Event.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/ParsingError.scala Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@dilyand dilyand force-pushed the release/1.0.0 branch 2 times, most recently from 0ee5f27 to 4a6656f Compare November 6, 2019 14:46
@dilyand dilyand force-pushed the release/1.0.0 branch 2 times, most recently from cf191a6 to 4a1d3b3 Compare November 6, 2019 15:16
@dilyand dilyand merged commit 9cad7e2 into master Nov 6, 2019
@benjben benjben deleted the release/1.0.0 branch October 26, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilyand dilyand dilyand approved these changes

@chuwy chuwy chuwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aldemirenes @benjben @dilyand @chuwy