BadRow sealed trait / BQ Loader bad rows #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a bug in the context decoder in Analytics SDK. I've solved this bug however did not release rc in case any problem. Therefore, that version of Analytics SDK need to be publish locally. You can find relevant PR in here: snowplow/snowplow-scala-analytics-sdk#89 |
aldemirenes
force-pushed
the
loader-bad-rows
branch
from
fa26206 to
c02be4b
Compare
benjben
force-pushed
the
loader-bad-rows
branch
2 times, most recently
from
189146b to
6d9fe3a
Compare
benjben
force-pushed
the
loader-bad-rows
branch
2 times, most recently
from
e2fd385 to
b91cae0
Compare
|
Commits cherry-picked in #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains necessary changes for making BadRow sealed trait and new BQ loader bad rows.
Verbose encoder and decoders are creating some clutters. There might be possible improvements in there. Also, property based tests are started to written for all bad rows. They are not fully finished but general test structure can be understood from existing tests. Also, while writing the property based tests for schema validation, some updates are made on the schemas. These updates can be found in here. Also, usage of BQ Loader bad rows can be seen in here.