Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty contexts and unstruct_event decoding #92

Closed
chuwy opened this issue Nov 4, 2019 · 0 comments
Closed

Fix empty contexts and unstruct_event decoding #92

chuwy opened this issue Nov 4, 2019 · 0 comments
Assignees
@dilyand
Labels
bug
Milestone
1.0.0

Comments

@chuwy
Copy link
Contributor

chuwy commented Nov 4, 2019

If we create a deeply nested JSON object with Event (such as Badrow) withou self-describing (contexts, unstruct_event) payloads and then try to decode it using SDK default decoders (which produce null) - it fails because both Context and UnstructEvent expected to be self-describing JSONs with schema and data, but they're nulls.
@chuwy chuwy added this to the Version 1.0.0 milestone Nov 4, 2019
@chuwy chuwy added the bug label Nov 4, 2019
dilyand pushed a commit that referenced this issue Nov 4, 2019
@aldemirenes @dilyand
Fix empty contexts and unstruct_event decoding (closes #92)
fa254ec
dilyand pushed a commit that referenced this issue Nov 4, 2019
@aldemirenes @dilyand
Fix empty contexts and unstruct_event decoding (closes #92)
d238c83
dilyand added a commit that referenced this issue Nov 4, 2019
@dilyand
Fix empty contexts and unstruct_event decoding (closes #92)
88d54b5
dilyand added a commit that referenced this issue Nov 4, 2019
@dilyand
Fix empty contexts and unstruct_event decoding (closes #92)
e71129f
dilyand pushed a commit that referenced this issue Nov 4, 2019
@aldemirenes @dilyand
Fix empty contexts and unstruct_event decoding (closes #92)
1c4717c
dilyand pushed a commit that referenced this issue Nov 6, 2019
@aldemirenes @dilyand
Fix empty contexts and unstruct_event decoding (closes #92)
903b07c
dilyand pushed a commit that referenced this issue Nov 6, 2019
@aldemirenes @dilyand
Fix empty contexts and unstruct_event decoding (closes #92)
99fb37d
dilyand pushed a commit that referenced this issue Nov 6, 2019
@aldemirenes @dilyand
Fix empty contexts and unstruct_event decoding (closes #92)
d72ec14
@dilyand dilyand closed this as completed in 583b2ed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dilyand dilyand

Labels
bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@chuwy @dilyand