Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1 0 x fixes #228

Merged
merged 8 commits into from
Oct 29, 2021
Merged

Feature/1 0 x fixes #228

merged 8 commits into from
Oct 29, 2021

Conversation

istreeter
Copy link
Contributor

No description provided.

@istreeter istreeter force-pushed the feature/1-0-x-fixes branch from e92500d to 9340ca8 Compare October 27, 2021 20:56
@istreeter
Copy link
Contributor Author

This includes everything in the 1.0.1 milestone, except for #48 . Which is partly because I don't fully understand what is required, and also because it is relatively minor importance. I would be happy to release 1.0.1 with this set of fixes only.

Copy link
Contributor

@benjben benjben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

val googleCloudBigQuery = "1.102.0" // no upgrade before bumping pubsubFs2
val googleCloudPubSub = "1.102.0" // no upgrade before bumping pubsubFs2
val googleCloudStorage = "1.102.0" // no upgrade before bumping pubsubFs2
val googleCloudBigQuery = "2.1.6" // compatible with google-cloud-pubsub:1.14.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val googleCloudBigQuery = "2.1.6" // compatible with google-cloud-pubsub:1.14.3
val googleCloudBigQuery = "2.1.6" // compatible with google-cloud-pubsub:1.114.3

val googleCloudStorage = "1.102.0" // no upgrade before bumping pubsubFs2
val googleCloudBigQuery = "2.1.6" // compatible with google-cloud-pubsub:1.14.3
val googleCloudPubSub = "1.114.3" // match the version of fs2-google-pubsub
val googleCloudStorage = "2.1.1" // compatible with google-cloud-pubsub:1.14.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val googleCloudStorage = "2.1.1" // compatible with google-cloud-pubsub:1.14.3
val googleCloudStorage = "2.1.1" // compatible with google-cloud-pubsub:1.114.3

@istreeter istreeter force-pushed the feature/1-0-x-fixes branch from 9340ca8 to ad4a4be Compare October 29, 2021 10:07
@istreeter istreeter merged commit 942f67c into develop Oct 29, 2021
@istreeter istreeter deleted the feature/1-0-x-fixes branch October 29, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants