Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeater: change filename logging level to info #222

Closed
chuwy opened this issue Oct 16, 2021 · 1 comment
Closed

Repeater: change filename logging level to info #222

chuwy opened this issue Oct 16, 2021 · 1 comment
Milestone
1.0.1

Comments

@chuwy
Copy link
Contributor

chuwy commented Oct 16, 2021

There's a lot of things printed in DEBUG level and most of them are really for debugging only, but filename logging is generally useful information showing that Repeater is working.

NB: getTime in that function is also useless
@chuwy
Copy link
Contributor Author

chuwy commented Oct 16, 2021

Also I just noticed it has the same problem as RDB Loader (snowplow/snowplow-rdb-loader#598), all logging comes from Repeater class, which shouldn't be the case.

@dilyand dilyand added this to the 1.0.1 milestone Oct 18, 2021
@istreeter istreeter mentioned this issue Oct 27, 2021
Open
istreeter added a commit that referenced this issue Oct 27, 2021
@istreeter
Repeater: change filename logging level to info (close #222)
7899242
istreeter added a commit that referenced this issue Oct 27, 2021
@istreeter
Repeater: change filename logging level to info (close #222)
bbb4955
istreeter added a commit that referenced this issue Oct 29, 2021
@istreeter
Repeater: change filename logging level to info (close #222)
00f3640
istreeter added a commit that referenced this issue Oct 29, 2021
@istreeter
Repeater: change filename logging level to info (close #222)
87eb32d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
2 participants
@chuwy @dilyand