Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeater: fix typos in cli options' help text #221

Closed
dilyand opened this issue Oct 8, 2021 · 0 comments
Closed

Repeater: fix typos in cli options' help text #221

dilyand opened this issue Oct 8, 2021 · 0 comments
Milestone

Comments

@dilyand
Copy link
Contributor

dilyand commented Oct 8, 2021

Options and flags:
  (...)  
  --bufferSize <integer>
        Some failed inserts cannot be written to BigQuery, even after multiple attempts. These events are buffered and ultimately sunk to GCS.The buffer is flushed when uninsertableBufferSize is reached or when uninsertableTimeout passes.
    --timeout <integer>
        Some failed inserts cannot be written to BigQuery, even after multiple attempts. These events are buffered and ultimately sunk to GCS.The buffer is flushed when uninsertableBufferSize is reached or when uninsertableTimeout passes.
    --backoffPeriod <integer>
        Time (in seconds) to wait before trying to re-insert the record(s).
    (...)

Mismatch between option names and how they are referenced in the help text, eg bufferSize vs uninsertableBufferSize.

Also, technically Repeater does not try to re-insert records, but rather re-tries inserting them.

@dilyand dilyand added this to the 1.0.1 milestone Oct 8, 2021
@dilyand dilyand changed the title Fix typos in Repeater cli options' help text Repeater: fix typos in cli options' help text Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant