Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dot, solidus, percent and colon characters in profile names #1067

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 9, 2023

Issue #, if available:
Fixes: aws/aws-sdk-js-v3#5449
Fixes: #1053
Refs: aws/aws-sdk-java-v2#1538
Refs: aws/aws-sdk-java-v2#1898

Description of changes:
Allow dot, solidus, percent and colon characters in profile names


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title Parse profile name with invalid '.' and './' characters Parse profile name with invalid '.' and '/' characters Nov 9, 2023
@trivikr trivikr changed the title Parse profile name with invalid '.' and '/' characters Allow invalid dot, slack, ampersand and percent characters in profile names Nov 9, 2023
@trivikr trivikr changed the title Allow invalid dot, slack, ampersand and percent characters in profile names Allow invalid dot, slash, ampersand and percent characters in profile names Nov 9, 2023
@trivikr trivikr changed the title Allow invalid dot, slash, ampersand and percent characters in profile names Allow invalid dot, solidus, ampersand and percent characters in profile names Nov 9, 2023
@trivikr trivikr changed the title Allow invalid dot, solidus, ampersand and percent characters in profile names Allow dot, solidus, ampersand and percent characters in profile names Nov 9, 2023
@trivikr trivikr changed the title Allow dot, solidus, ampersand and percent characters in profile names Allow dot, solidus, percent and colon characters in profile names Nov 9, 2023
@trivikr trivikr marked this pull request as ready for review November 9, 2023 18:03
@trivikr trivikr requested review from a team as code owners November 9, 2023 18:03
@trivikr trivikr merged commit c27879f into smithy-lang:main Nov 9, 2023
7 checks passed
@trivikr trivikr deleted the profile-name-with-dot-character branch November 9, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants