Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for : in profile names #1898

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Add support for : in profile names #1898

merged 3 commits into from
Jun 30, 2020

Conversation

leepa
Copy link
Contributor

@leepa leepa commented Jun 15, 2020

Description

Fixes #1847 by adding support for a colon in a profile name

Motivation and Context

To support profiles with colons (:) in the name

Testing

Updated Unit Testing and ran

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #1898 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1898      +/-   ##
============================================
- Coverage     76.25%   76.24%   -0.02%     
  Complexity      187      187              
============================================
  Files          1076     1076              
  Lines         32573    32573              
  Branches       2569     2569              
============================================
- Hits          24840    24835       -5     
- Misses         6471     6478       +7     
+ Partials       1262     1260       -2     
Flag Coverage Δ Complexity Δ
#unittests 76.24% <100.00%> (-0.02%) 187.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
...on/awssdk/profiles/internal/ProfileFileReader.java 93.38% <100.00%> (ø) 0.00 <0.00> (ø)
...ttp/nio/netty/internal/nrs/HttpStreamsHandler.java 60.76% <0.00%> (-3.85%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9772428...1711df2. Read the comment docs.

@millems
Copy link
Contributor

millems commented Jun 30, 2020

Thanks for your contribution! Once merged, this will go out with the next release.

@millems millems merged commit 0883321 into aws:master Jun 30, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support colon (:) in profile names
3 participants