-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not support "." (dots) in profile names #1163
Comments
It seems like the fix would be to change that line for: .reduce((acc, [key, value]) => ({ ...acc, [key.split(CONFIG_PREFIX_SEPARATOR).slice(1).join(CONFIG_PREFIX_SEPARATOR)]: value }), {}); |
@trivikr says the fix was released in @smithy/[email protected] |
The feature request was implemented in We'll have to get a minimal repro, and investigate what role |
Reproduction code $ cat test.mjs
import { loadSsoSessionData } from "@smithy/shared-ini-file-loader"; // v2.3.3
console.log(await loadSsoSessionData());
$ cat ~/.aws/config
[profile my.big.profile]
region = us-east-1
sso_session = my.sso
sso_account_id = 123456789
sso_role_name = BigRole
[sso-session my.sso]
sso_region = us-east-1
sso_start_url = https://magic-app.awsapps.com/start
sso_registration_scopes = sso:account:access
$ node test.mjs
{
my: {
sso_region: 'us-east-1',
sso_start_url: 'https://magic-app.awsapps.com/start',
sso_registration_scopes: 'sso:account:access'
}
} The change requested is for output to be: $ node test.mjs
{
'my.sso': {
sso_region: 'us-east-1',
sso_start_url: 'https://magic-app.awsapps.com/start',
sso_registration_scopes: 'sso:account:access'
}
} |
Given this ~/.aws/config INI:
The loadSsoSessionData returns an object where the key is
my
instead ofmy.sso
. This breaks the fromSso function which tries to get the session data usingmy.sso
, literally.This is a limitation of the AWS SDK for JS v3, as the
aws
CLI and the golang SDK support SSO sessions with dots in their names just fine.The text was updated successfully, but these errors were encountered: