Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ingress to route on openshift #1459

Conversation

Karen-Schoener
Copy link
Collaborator

On openshift, if skupper init is called with ingress='' or with no ingress param specified, default ingress to route.

Fixes #1424

On openshift, if skupper init is called with ingress='' or
with no ingress param specified, default ingress to route.

Fixes skupperproject#1424
@Karen-Schoener
Copy link
Collaborator Author

Marking as draft. Plan to test more before asking for review comments.

@Karen-Schoener Karen-Schoener marked this pull request as draft April 26, 2024 20:41
@Karen-Schoener
Copy link
Collaborator Author

Tested with minikube: ./skupper init

  $ ./skupper init
  $ kubectl get configmap skupper-site -o yaml | grep ingress
  ingress: loadbalancer

Tested with minikube: ./skupper init --ingress ''

  $ ./skupper init --ingress '' 
  $   kubectl get configmap skupper-site -o yaml | grep ingress
  ingress: loadbalancer

Tested with openshift-local: ./skupper init

  $ ./skupper init
  $ oc get configmap skupper-site -o yaml | grep ingress
  ingress: route

Tested with openshift-local: ./skupper init --ingress ''

  $ ./skupper init --ingress '' 
  $ oc get configmap skupper-site -o yaml | grep ingress
  ingress: route

@Karen-Schoener Karen-Schoener marked this pull request as ready for review April 29, 2024 20:52
@Karen-Schoener
Copy link
Collaborator Author

Removed draft label.

Copy link
Member

@grs grs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

@grs grs merged commit 9fd6cb6 into skupperproject:main May 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skupper init with ingress set to empty string makes LoadBalancer as the default on Openshift
3 participants