Skip to content

Commit

Permalink
Default ingress to route on openshift
Browse files Browse the repository at this point in the history
On openshift, if skupper init is called with ingress='' or
with no ingress param specified, default ingress to route.

Fixes #1424
  • Loading branch information
Karen-Schoener authored and grs committed May 1, 2024
1 parent cb7ff73 commit 9fd6cb6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/skupper/skupper_kube_site.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func (s *SkupperKubeSite) Create(cmd *cobra.Command, args []string) error {
routerIngressFlag := cmd.Flag("ingress")
routerCreateOpts.Platform = s.kube.Platform()

if !routerIngressFlag.Changed {
if !routerIngressFlag.Changed || routerCreateOpts.Ingress == "" {
routerCreateOpts.Ingress = cli.GetIngressDefault()
}
if routerCreateOpts.Ingress == types.IngressNodePortString && routerCreateOpts.IngressHost == "" && routerCreateOpts.Router.IngressHost == "" {
Expand Down

0 comments on commit 9fd6cb6

Please sign in to comment.