Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skupper init with ingress set to empty string makes LoadBalancer as the default on Openshift #1424

Closed
granzoto opened this issue Mar 28, 2024 · 1 comment · Fixed by #1459
Closed

skupper init with ingress set to empty string makes LoadBalancer as the default on Openshift #1424

granzoto opened this issue Mar 28, 2024 · 1 comment · Fixed by #1459
Assignees
@Karen-Schoener
Labels
bug Something isn't working cli-changes good first issue Good for newcomers

Comments

@granzoto
Copy link
Contributor

Describe the bug
skupper init --ingress '' on Openshift, assumes that LoadBalancer should be used as the default ingress
An empty value should also make skupper pick the default for the proper k8s flavor, in this case, route for OCP.

How To Reproduce
On a OCP cluster :
skupper init --ingress ''

Expected behavior
Expect route to be used as the ingress.

Environment details

  • Skupper CLI: 1.5.3
  • Skupper Operator : NA
  • Platform: openshift
@granzoto granzoto added bug Something isn't working cli-changes labels Mar 28, 2024
@fgiorgetti fgiorgetti added the good first issue Good for newcomers label Apr 18, 2024
@Karen-Schoener
Copy link
Collaborator

Just fyi, I am starting to investigate this ticket. Thanks, Karen

Karen-Schoener added a commit to Karen-Schoener/skupper that referenced this issue Apr 26, 2024
@Karen-Schoener
Default ingress to route on openshift
ece5cb3 
On openshift, if skupper init is called with ingress='' or
with no ingress param specified, default ingress to route.

Fixes skupperproject#1424
@Karen-Schoener Karen-Schoener mentioned this issue Apr 26, 2024
Merged
@grs grs closed this as completed in #1459 May 1, 2024
grs pushed a commit that referenced this issue May 1, 2024
@Karen-Schoener @grs
Default ingress to route on openshift
9fd6cb6 
On openshift, if skupper init is called with ingress='' or
with no ingress param specified, default ingress to route.

Fixes #1424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karen-Schoener Karen-Schoener

Labels
bug Something isn't working cli-changes good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default ingress to route on openshift Karen-Schoener/skupper
3 participants
@fgiorgetti @granzoto @Karen-Schoener