Fixes #651: Frees the qdr_connection_t and qdr_http2_connection_t obj… #652
Conversation
…nnection_t object leaks by freeing them when a closed connection is being activated
| if (connector->ctx) | ||
| qdr_core_close_connection((qdr_connection_t *)connector->ctx); | ||
| if (connector->ctx) { | ||
| qdr_connection_t *conn = (qdr_connection_t *)connector->ctx; |
There was a problem hiding this comment.
this line is not according to clang-format, it is not aligned with the lane below
There was a problem hiding this comment.
$ sudo dnf install git-clang-format
$ git clang-format -f
should be the magic (to format outstanding changes)
There was a problem hiding this comment.
We should make the clang-format as part of the build ASAP. We should just bite the bullet and do it. I will fix this. Thx.
There was a problem hiding this comment.
Maybe we can make git clang-format be part of precommit checks. Therefore, all new (added or modified) code will have to be formatted, while old code can remain unchanged.
Advantage: it should be reatively painless.
There was a problem hiding this comment.
I think we should do what you did earlier which is agree on a clang format, format all the code in the repo by running the tool and check all that modified code back into the repo. Then enable the tool in cmake so that it fails the build (locally and on CI) if the code violates the format. This is what I meant by bite the bullet and do it. :)
In other words, this should work very similar to the python-checker if possible
There was a problem hiding this comment.
I know. I proposed to do this in two steps, instead, and soften the bullet for the first step.
There was a problem hiding this comment.
@jiridanek 2 steps most definitely
There was a problem hiding this comment.
…ect leaks by freeing them when a closed connection is being activated