Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat all code according to clang-format #661

Closed
jiridanek opened this issue Aug 5, 2022 · 4 comments
Closed

Reformat all code according to clang-format #661

jiridanek opened this issue Aug 5, 2022 · 4 comments
Assignees

Comments

@jiridanek
Copy link
Contributor

This follows up to

@jiridanek
Copy link
Contributor Author

  • CI job to check that everything is formatted; not sure if git precommit is sufficient guarantee of that or not

@jiridanek
Copy link
Contributor Author

There is no format but clang-format and everything is to be accomplished according to the will of clang-format.

@ganeshmurthy ganeshmurthy added this to the 2.4.0 milestone Feb 6, 2023
@ganeshmurthy ganeshmurthy modified the milestones: 2.4.0, 2.5.0 Apr 12, 2023
@jiridanek
Copy link
Contributor Author

This is not going to happen. The clang format config file remains in the repository and everyone is free to use it, regarding e.g. * alignment in pointer declarations.

It is generally felt that clang format is too strict and it goes too strongly against people's wishes.

We should add

SeparateDefinitionBlocks: Leave

to the clang config, though.

@jiridanek
Copy link
Contributor Author

Here is the issue about "LeaveAlone"

Interestingly, there are four option that currently take "Leave" as an value, such as that SeparateDefinitionBlocks thing.

Maybe it will happen one day and clang-format will be more like go fmt in this way.

@jiridanek jiridanek closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2023
@jiridanek jiridanek self-assigned this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants