Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git precommit with clang-format #660

Closed
jiridanek opened this issue Aug 5, 2022 · 2 comments · Fixed by #663 or #669 · May be fixed by #662
Closed

Add git precommit with clang-format #660

jiridanek opened this issue Aug 5, 2022 · 2 comments · Fixed by #663 or #669 · May be fixed by #662
Assignees
Labels
task Minor work item - not a bug or feature
Milestone

Comments

@jiridanek
Copy link
Contributor

This follows up to

@jiridanek
Copy link
Contributor Author

jiridanek commented Aug 5, 2022

There are two possibilities, either write the hook from scratch, or use one of the hook frameworks

@jiridanek
Copy link
Contributor Author

https://github.com/pre-commit/pre-commit only works on the file-level, that is, check succeeds only if the whole file is properly formatted. What we want (for now) is to only check formatting of the changed lines.

@jiridanek jiridanek linked a pull request Aug 5, 2022 that will close this issue
@jiridanek jiridanek self-assigned this Aug 5, 2022
@jiridanek jiridanek added this to the 2.1.0 milestone Aug 5, 2022
@jiridanek jiridanek added the task Minor work item - not a bug or feature label Aug 5, 2022
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Aug 5, 2022
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Aug 5, 2022
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Aug 5, 2022
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Aug 5, 2022
@jiridanek jiridanek linked a pull request Aug 5, 2022 that will close this issue
@jiridanek jiridanek linked a pull request Aug 9, 2022 that will close this issue
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment