Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-ui): support 8px theme #2322

Merged
merged 18 commits into from
Apr 9, 2021
Merged

feat(react-ui): support 8px theme #2322

merged 18 commits into from
Apr 9, 2021

Conversation

zhzz
Copy link
Member

@zhzz zhzz commented Mar 18, 2021

Общая ветка для готовых PR c 8px-темой.

Влито:

@vercel
Copy link

vercel bot commented Mar 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storybook-flat – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-flat/AubDyRAsdUgV1Mvr6ihCmRcKmjFo
✅ Preview: https://storybook-flat-git-theme-8px-all-reactui.vercel.app

storybook-default – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-default/2L9fvCF1jympSUsD5EqoxaKcBkM9
✅ Preview: https://storybook-default-git-theme-8px-all-reactui.vercel.app

storybook-8px – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-8px/5cQfyTQMbeH2ESxxM1EbuUay8oHP
✅ Preview: https://storybook-8px-git-theme-8px-all-reactui.vercel.app

@zhzz zhzz mentioned this pull request Mar 18, 2021
@vercel vercel bot temporarily deployed to Preview – retail-ui-default-8px March 18, 2021 11:20 Inactive
@vercel vercel bot temporarily deployed to Preview – retail-ui-default March 18, 2021 11:20 Inactive
fix(Toast): compensate font-family baseline, change spacing
@vercel vercel bot temporarily deployed to Preview – retail-ui-default-8px March 19, 2021 11:52 Inactive
@vercel vercel bot temporarily deployed to Preview – retail-ui-default March 19, 2021 11:52 Inactive
@vercel vercel bot temporarily deployed to Preview – retail-ui-default-8px March 19, 2021 13:38 Inactive
@vercel vercel bot temporarily deployed to Preview – retail-ui-default March 19, 2021 13:38 Inactive
@StathamJason
Copy link
Contributor

StathamJason commented Mar 22, 2021

Необходимо изменить в 8px toastPaddingY на 10px по макету

@zhzz
Copy link
Member Author

zhzz commented Mar 22, 2021

Необходимо изменить в 8px toastPaddingY на 10px по макету

Там же и есть 10px. Но после компенсации бэйслайна получается 9px и 11px сверху и снизу. Эта компенсация кое-где применяется чтобы выровнять базовую линию текста в шрифте Segoe UI, которая кривая.

@vercel vercel bot temporarily deployed to Preview – storybook-flat March 22, 2021 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 22, 2021 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 22, 2021 12:55 Inactive
Co-authored-by: Голубев Олег Игоревич <[email protected]>
@vercel vercel bot temporarily deployed to Preview – storybook-default March 23, 2021 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 23, 2021 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 23, 2021 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 23, 2021 17:56 Inactive
Co-authored-by: Голубев Олег Игоревич <[email protected]>
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 24, 2021 12:49 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 24, 2021 12:49 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 24, 2021 12:49 Inactive
Co-authored-by: Голубев Олег Игоревич <[email protected]>
@vercel vercel bot temporarily deployed to Preview – storybook-default March 25, 2021 12:54 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 25, 2021 12:54 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 25, 2021 12:54 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 26, 2021 05:27 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 26, 2021 05:27 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 26, 2021 05:27 Inactive
Co-authored-by: Голубев Олег Игоревич <[email protected]>
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 26, 2021 08:59 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 26, 2021 08:59 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 26, 2021 08:59 Inactive
@dzekh
Copy link

dzekh commented Mar 30, 2021

  • Нужно на 1px увеличить отступ сверху и снизу у менюатем. Для этого его лучше отвязать от глобальных отступов контролов.
  • Стиль обводки и тени дропдаунменю селекта и других выпадашек не совпадает с дизайном. Было бы круто в рамках этого пиара или отдельно поправить в 3.0:box-shadow: 0px 4px 12px 0px #000000 16%;

Нужно сделать пару изменений в стайлгайдисте, потому что появились отступы у радиокнопок и чекбоксов:

  • В стайлгайдсте в тултипе в примере «Выравнивание базовой линии с RadioGroup требует дополнительных отступов» нужно изменить пример: убрать отступ <Gapped vertical gap={0}> и поменять паддинг у дива: <div style={{ padding: '10px 0', display: 'inline-block' }}>
  • В радиокнопке в стайлгайдисте <Gapped vertical gap={10}> 10 исправить на 0

@zhzz
Copy link
Member Author

zhzz commented Apr 8, 2021

@dzekh поменяли тени у всех выпадашек в 8px. Заапрувь если можешь)

Demo: https://popups8px.vercel.app

Tooltip Select TooltipMenu Autocomplete
image image image image

и тд


Немного сливается, если фон не чисто белый:

image

@zhzz zhzz marked this pull request as ready for review April 8, 2021 13:09
@zhzz zhzz requested review from StathamJason and lossir April 8, 2021 13:09
@zhzz zhzz merged commit f6ac143 into master Apr 9, 2021
@zhzz zhzz deleted the theme-8px/all branch April 9, 2021 06:39
@zhzz zhzz mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants