Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme 8px/datepicker #2224

Merged
merged 7 commits into from
Mar 26, 2021
Merged

Theme 8px/datepicker #2224

merged 7 commits into from
Mar 26, 2021

Conversation

rustho
Copy link
Contributor

@rustho rustho commented Nov 26, 2020

No description provided.

@rustho rustho requested review from lossir and zhzz November 26, 2020 14:04
@vercel
Copy link

vercel bot commented Mar 18, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storybook-flat – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-flat/9HtbREyxeKtxEkpSk6TXBhcD11nq
✅ Preview: https://storybook-flat-git-theme-8px-datepicker-reactui.vercel.app

storybook-8px – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-8px/2fTuEn6SYWsdNaXb9vLxBades22x
✅ Preview: https://storybook-8px-git-theme-8px-datepicker-reactui.vercel.app

storybook-default – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-default/6Nax69cJPG1xWKoajXJuRH2oBeSt
✅ Preview: https://storybook-default-git-theme-8px-datepicker-reactui.vercel.app

@vercel vercel bot temporarily deployed to Preview March 18, 2021 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – retail-ui-default March 18, 2021 12:57 Inactive
@vercel vercel bot temporarily deployed to Preview – retail-ui-default-8px March 18, 2021 12:57 Inactive
@zhzz zhzz mentioned this pull request Mar 19, 2021
Merged
14 tasks
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 24, 2021 08:17 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 24, 2021 08:17 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 24, 2021 08:17 Inactive
@zhzz zhzz force-pushed the theme-8px/datepicker branch from b4fd523 to 3dd6a0b Compare March 24, 2021 10:48
@vercel vercel bot temporarily deployed to Preview – storybook-default March 24, 2021 10:48 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 24, 2021 10:48 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 24, 2021 10:48 Inactive
@zhzz zhzz force-pushed the theme-8px/datepicker branch from 3dd6a0b to f71f357 Compare March 24, 2021 15:02
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 24, 2021 15:02 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 24, 2021 15:02 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 24, 2021 15:02 Inactive
@zhzz zhzz force-pushed the theme-8px/datepicker branch from f71f357 to d025c75 Compare March 25, 2021 11:51
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 25, 2021 11:51 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 25, 2021 11:51 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 25, 2021 11:51 Inactive
@zhzz
Copy link
Member

zhzz commented Mar 25, 2021

  1. Допилил верстку согласно макетам. По пути мы с Вовой там подправили размеры ячейки, сделали ее обратно квадратной
  2. Сделал высоту месяца в модели функцией от темы, вернув мемоизацию там, где она была, и добавил ее в конфиг тоже.
  3. Переименовал некоторые переменные

@zhzz zhzz marked this pull request as ready for review March 25, 2021 11:51
@zhzz zhzz requested a review from StathamJason March 25, 2021 12:27
@zhzz zhzz changed the base branch from master to theme-8px/all March 25, 2021 12:55
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 25, 2021 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 25, 2021 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 25, 2021 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 26, 2021 08:53 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 26, 2021 08:53 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 26, 2021 08:53 Inactive
@zhzz zhzz merged commit 24d8469 into theme-8px/all Mar 26, 2021
@zhzz zhzz deleted the theme-8px/datepicker branch March 26, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StathamJason StathamJason StathamJason approved these changes

@lossir lossir Awaiting requested review from lossir

@zhzz zhzz Awaiting requested review from zhzz

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustho @zhzz @StathamJason