Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme-8px/hint #2166

Merged
merged 9 commits into from
Mar 23, 2021
Merged

Theme-8px/hint #2166

merged 9 commits into from
Mar 23, 2021

Conversation

rustho
Copy link
Contributor

@rustho rustho commented Oct 8, 2020

Добавил переменные для 8пиксельной темы для hint

@rustho rustho marked this pull request as draft October 13, 2020 13:04
@rustho rustho marked this pull request as ready for review November 17, 2020 08:12
Copy link
Member

@zhzz zhzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В 8px-теме отступ от клюва получился меньше, чем нужно.

image

@StathamJason
Copy link
Contributor

Делал ребейз и он почему-то размотал мердж коммит на отдельные

@StathamJason StathamJason requested a review from zhzz March 5, 2021 12:54
@vercel
Copy link

vercel bot commented Mar 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storybook-flat – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-flat/7HRnVm3BioKU12DqLMc1TLRsAYrN
✅ Preview: https://storybook-flat-git-theme-8px-hint-reactui.vercel.app

[Deployment for 29bb414 failed]

storybook-default – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-default/4FGhn1UqajMS9ruA2hSzzu7cVfS8
✅ Preview: https://storybook-default-git-theme-8px-hint-reactui.vercel.app

[Deployment for 29bb414 failed]

storybook-8px – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-8px/nGaQJ8cCYy16XNfsqvHBPiMzZzEG
✅ Preview: https://storybook-8px-git-theme-8px-hint-reactui.vercel.app

@vercel vercel bot temporarily deployed to Preview – retail-ui-default March 18, 2021 10:27 Inactive
@vercel vercel bot temporarily deployed to Preview – retail-ui-default-8px March 18, 2021 10:27 Inactive
@zhzz zhzz mentioned this pull request Mar 19, 2021
14 tasks
@vercel vercel bot temporarily deployed to Preview – retail-ui-default March 19, 2021 12:47 Inactive
@vercel vercel bot temporarily deployed to Preview – retail-ui-default-8px March 19, 2021 12:47 Inactive
@StathamJason StathamJason requested a review from zhzz March 19, 2021 12:48
@vercel vercel bot temporarily deployed to Preview – retail-ui-default March 19, 2021 13:42 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 23, 2021 10:32 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 23, 2021 10:32 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 23, 2021 10:32 Inactive
@zhzz zhzz changed the base branch from master to theme-8px/all March 23, 2021 17:29
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 23, 2021 17:34 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 23, 2021 17:34 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 23, 2021 17:34 Inactive
@zhzz zhzz merged commit a05b786 into theme-8px/all Mar 23, 2021
@zhzz zhzz deleted the theme-8px/hint branch March 23, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants